Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TrainerProperties Mixin and move property definitions directly into trainer.py #9495

Merged
merged 12 commits into from
Sep 18, 2021
Merged

Deprecate TrainerProperties Mixin and move property definitions directly into trainer.py #9495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4d5e38b
deprecate trainerproperties mixin and move properties to trainer.py
daniellepintz Sep 13, 2021
d81d126
update changelog
daniellepintz Sep 13, 2021
d886f17
Merge branch 'master' of https://github.com/PyTorchLightning/pytorch-…
daniellepintz Sep 13, 2021
0ce74fc
further cleanup
daniellepintz Sep 13, 2021
0298bcf
fix for LightningOptimizer
daniellepintz Sep 13, 2021
f8afa0a
move props to bottom of file
daniellepintz Sep 15, 2021
e00bacf
Merge branch 'master' of https://github.com/PyTorchLightning/pytorch-…
daniellepintz Sep 15, 2021
815c692
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 15, 2021
1e0ec9e
Merge branch 'master' of https://github.com/PyTorchLightning/pytorch-…
daniellepintz Sep 15, 2021
e1417c8
Merge branch 'mixin' of github.com:daniellepintz/pytorch-lightning in…
daniellepintz Sep 15, 2021
238eb1c
Update CHANGELOG.md
daniellepintz Sep 16, 2021
15ff2b4
Merge branch 'master' into mixin
tchaton Sep 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Executing the `optimizer_closure` is now required when overriding the `optimizer_step` hook ([#9360](https://github.com/PyTorchLightning/pytorch-lightning/pull/9360))


- Removed `TrainerProperties` mixin and moved property definitions directly into `Trainer` ([#9495](https://github.com/PyTorchLightning/pytorch-lightning/pull/9495))


- Changed logging of `LightningModule` and `LightningDataModule` hyperparameters to raise an exception only if there are colliding keys with different values ([#9496](https://github.com/PyTorchLightning/pytorch-lightning/pull/9496))


Expand Down
Loading