-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put back initialization of properties in trainer #9594
Merged
daniellepintz
merged 14 commits into
Lightning-AI:master
from
daniellepintz:fix_trainer_mixin
Sep 18, 2021
Merged
Put back initialization of properties in trainer #9594
daniellepintz
merged 14 commits into
Lightning-AI:master
from
daniellepintz:fix_trainer_mixin
Sep 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
12 tasks
ananthsub
approved these changes
Sep 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #9594 +/- ##
=======================================
- Coverage 92% 89% -3%
=======================================
Files 181 180 -1
Lines 15728 15305 -423
=======================================
- Hits 14446 13586 -860
- Misses 1282 1719 +437 |
tchaton
approved these changes
Sep 18, 2021
justusschock
approved these changes
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
trainer.py
#9495 and pointed out by @carmocca. Put back properties that should have been initialized in trainertrainer.py
#9495 that caused this file to not be deletedDoes your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃