This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
IceVision integration #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ethanwharris! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-12 12:41:35 UTC |
8 tasks
tchaton
reviewed
Jul 21, 2021
Comment on lines
46
to
79
| class IceVisionParserDataSource(IceVisionPathsDataSource): | ||
|
|
||
| def __init__(self, parser: Optional[Type['Parser']] = None): | ||
| super().__init__() | ||
| self.parser = parser | ||
|
|
||
| def load_data(self, data: Tuple[str, str], dataset: Optional[Any] = None) -> Sequence[Dict[str, Any]]: | ||
| root, ann_file = data | ||
|
|
||
| if self.parser is not None: | ||
| parser = self.parser(ann_file, root) | ||
| dataset.num_classes = len(parser.class_map) | ||
| records = parser.parse(data_splitter=SingleSplitSplitter()) | ||
| return [{DefaultDataKeys.INPUT: record} for record in records[0]] | ||
| else: | ||
| raise ValueError("The parser type must be provided") | ||
|
|
||
|
|
||
| class IceDataParserDataSource(IceVisionPathsDataSource): | ||
|
|
||
| def __init__(self, parser: Optional[Callable] = None): | ||
| super().__init__() | ||
| self.parser = parser | ||
|
|
||
| def load_data(self, data: Tuple[str, str], dataset: Optional[Any] = None) -> Sequence[Dict[str, Any]]: | ||
| root = data | ||
|
|
||
| if self.parser is not None: | ||
| parser = self.parser(root) | ||
| dataset.num_classes = len(parser.class_map) | ||
| records = parser.parse(data_splitter=SingleSplitSplitter()) | ||
| return [{DefaultDataKeys.INPUT: record} for record in records[0]] | ||
| else: | ||
| raise ValueError("The parser must be provided") |
There was a problem hiding this comment.
Could they be merged together ?
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
- Coverage 90.58% 90.01% -0.58%
==========================================
Files 173 185 +12
Lines 9232 9663 +431
==========================================
+ Hits 8363 8698 +335
- Misses 869 965 +96
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ethanwharris
requested review from
carmocca,
edenlightning,
justusschock and
kaushikb11
as code owners
Borda
reviewed
Aug 11, 2021
| @@ -0,0 +1,31 @@ | |||
|
|
|||
| .. _instance_segmentation: | |||
There was a problem hiding this comment.
we can have these labels automatically generated by docs
3 tasks
tchaton
reviewed
Aug 12, 2021
tchaton
approved these changes
Aug 12, 2021
| pass | ||
|
|
||
|
|
||
| class AdapterTask(Task): |
There was a problem hiding this comment.
Could the AdapterTask use the mixins ?
ananyahjha93
approved these changes
Aug 16, 2021
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #487
Fixes #480
Fixes #119
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃