[WIP] IceVision Integration #408
Conversation
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
- Coverage 91.31% 85.22% -6.10%
==========================================
Files 112 113 +1
Lines 7061 7091 +30
==========================================
- Hits 6448 6043 -405
- Misses 613 1048 +435
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| if _ICEVISION_AVAILABLE: | ||
| import icevision | ||
|
|
||
| OBJECT_DETECTION_MODELS = FlashRegistry("backbones") |
There was a problem hiding this comment.
Could we call this OBJECT_DETECTION_HEADS instead?
| OBJECT_DETECTION_BACKBONES(partial(load_backbone, _faster_rcnn), name='fasterrcnn') | ||
| OBJECT_DETECTION_BACKBONES(partial(load_backbone, _yolov5), name='yolov5') | ||
|
|
||
| @OBJECT_DETECTION_MODELS(name='icevision') |
There was a problem hiding this comment.
Better to register each head here, so name should be e.g. retinanet, faster_rcnn, yolov5, etc.
| @@ -126,6 +127,12 @@ def get_model( | |||
| anchor_generator, | |||
| **kwargs, | |||
| ): | |||
| if _ICEVISION_AVAILABLE: | |||
There was a problem hiding this comment.
Shouldn't need a check here as the backbones will only be registered if the library is available.
| @@ -74,7 +74,8 @@ class ObjectDetector(Task): | |||
|
|
|||
| """ | |||
|
|
|||
| backbones: FlashRegistry = OBJ_DETECTION_BACKBONES | |||
| backbones: FlashRegistry = OBJECT_DETECTION_BACKBONES | |||
| models: FlashRegistry = OBJECT_DETECTION_MODELS | |||
There was a problem hiding this comment.
Let's call this heads as well :)
|
Closing this in favour of #608 |
What does this PR do?
#119 - integration of IceVision
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃