Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CLI train #1

Merged
merged 6 commits into from
Aug 19, 2021
Merged

add CLI train #1

merged 6 commits into from
Aug 19, 2021

Conversation

Borda
Copy link
Owner

@Borda Borda commented Aug 12, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

add trainable CLI script

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Aug 12, 2021
@Borda
Copy link
Owner Author

Borda commented Aug 12, 2021

waiting for Flash v0.5 release as the development and notebook was using a feature branch Lightning-Universe/lightning-flash#608

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #1 (c78afd0) into main (9b203e0) will decrease coverage by 4%.
The diff coverage is 54%.

@@        Coverage Diff         @@
##           main    #1   +/-   ##
==================================
- Coverage    84%   80%   -4%     
==================================
  Files         2     3    +1     
  Lines        76    89   +13     
==================================
+ Hits         64    71    +7     
- Misses       12    18    +6     

@Borda Borda merged commit 03727f3 into main Aug 19, 2021
@Borda Borda deleted the cli branch August 19, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant