Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun if PYO3_CROSS env variable changes. #1552

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

jameshilliard
Copy link
Contributor

Looks like I missed this in #1514.

Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@messense messense merged commit 7ac7536 into PyO3:main Apr 9, 2021
@jameshilliard jameshilliard deleted the cross-rerun branch April 9, 2021 19:01
@davidhewitt
Copy link
Member

I must have missed this from #1514 - what's the purpose of the PYO3_CROSS env var? It's not documented; it looks like #1514 introduced this, but it doesn't do anything special except force cross compilation. However at least PYO3_CROSS_LIB_DIR is also required at the same time, so it doesn't seem that there's a point to having a separate PYO3_CROSS variable...

@jameshilliard
Copy link
Contributor Author

I must have missed this from #1514 - what's the purpose of the PYO3_CROSS env var?

Oh, I think I was using that so that I could ensure pyo3 was running in cross compilation mode for cases where PYO3_CROSS_LIB_DIR is getting set in a different part of the build system. There's basically a chain of build systems when I cross compile, buildroot being the meta build system which invokes the setuptools build system which then invokes pyo3 using the cargo build system. So I had added that so at any point cross compilation can be turned on from any build system essentially to ensure one gets a useful error message in the event something in the build chain doesn't set PYO3_CROSS_LIB_DIR. Also added it so that we have a way to force cross compilation without affecting anything else in the event PYO3_CROSS_LIB_DIR gets removed/changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants