build: avoid rebuilds when using clippy in a virtualenv #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
cargo-clippy-rebuilds
branch
from
944a9c2 to
4f1b9db
Compare
|
(Ah sorry just seen your other comment, I'll restore |
davidhewitt
force-pushed
the
cargo-clippy-rebuilds
branch
3 times, most recently
from
60a0db6 to
4cd39a4
Compare
davidhewitt
force-pushed
the
cargo-clippy-rebuilds
branch
2 times, most recently
from
f1c5def to
c3b4511
Compare
|
If nobody has any objections, I'll probably merge this later today. I think it's a useful tidy up that can avoid some user frustration. |
davidhewitt
force-pushed
the
cargo-clippy-rebuilds
branch
from
c3b4511 to
2b9085a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1551
The fix comes in two pieces:
VIRTUAL_ENVandCONDA_PREFIXvariables as possible ways to detect the Python interpreter; this logic is borrowed frommaturin.rerun-if-env-changedsystem to ensure we emit exactly the environment variables checked by the current run of the build script. This should avoid issues like Rerun if PYO3_CROSS env variable changes. #1552 .cc @jameshilliard I took out the (new, undocumented)PYO3_CROSSvariable - was there a specific need for its creation?