Skip to content

fix: ignore develop artifacts for all binding types during build #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
messense merged 1 commit into from
Feb 21, 2026
Merged

fix: ignore develop artifacts for all binding types during build #3026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions src/module_writer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,18 +170,9 @@ pub fn write_python_part(
}
let relative = absolute.strip_prefix(python_dir).unwrap();
if !absolute.is_dir() {
// Ignore native libraries from develop, if any
if let Some(file_name) = relative.file_name() {
let file_name = file_name.to_string_lossy();
if file_name.starts_with(&project_layout.extension_name)
&& (file_name.ends_with(".so")
|| file_name.ends_with(".pyd")
|| file_name.ends_with(".dll")
|| file_name.ends_with(".dylib"))
{
debug!("Ignoring native library {}", relative.display());
continue;
}
if is_develop_native_library(relative, &project_layout.extension_name) {
debug!("Ignoring native library {}", relative.display());
continue;
}
#[cfg(unix)]
let mode = absolute.metadata()?.permissions().mode();
Expand Down Expand Up @@ -392,6 +383,31 @@ pub fn write_pth(
Ok(())
}

/// Check if a file is a native library artifact left behind by `maturin develop`.
///
/// `maturin develop` copies compiled extension modules (`.so`, `.pyd`, `.dll`, `.dylib`)
/// directly into the Python source tree for editable installs. When `maturin build` later
/// walks the same source tree to collect files for the wheel, these artifacts must be
/// skipped to avoid conflicts with the freshly compiled library being added to the wheel.
///
/// The artifacts follow different naming conventions depending on the binding type:
/// - **PyO3/pyo3-ffi**: `{ext_name}.cpython-3XX-*.so`, `{ext_name}.abi3.so`, `{ext_name}.pyd`
/// - **CFFI**: `lib{ext_name}.so`, `lib{ext_name}.dylib` (Unix), `{ext_name}.dll` (Windows)
/// - **UniFFI**: `lib{ext_name}.so`, `lib{ext_name}.dylib` (Unix), `{ext_name}.dll` (Windows)
fn is_develop_native_library(relative_path: &Path, extension_name: &str) -> bool {
let Some(file_name) = relative_path.file_name() else {
return false;
};
let file_name = file_name.to_string_lossy();
let is_native_ext = file_name.ends_with(".so")
|| file_name.ends_with(".pyd")
|| file_name.ends_with(".dll")
|| file_name.ends_with(".dylib");
is_native_ext
&& (file_name.starts_with(extension_name)
|| file_name.starts_with(&format!("lib{extension_name}")))
}

fn expand_compressed_tag(tag: &str) -> impl Iterator<Item = String> + '_ {
tag.split('-')
.map(|component| component.split('.'))
Expand Down
Loading