Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the name of the .data directory in the generated wheel #2449

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

ejd
Copy link
Contributor

@ejd ejd commented Jan 23, 2025

The basename of the ".data" directory in the wheel now matches the basename of the ".dist-info" directory, as per the wheel spec[1], like so:

 distribution-1.0.dist-info
 distribution-1.0.data

1: https://packaging.python.org/en/latest/specifications/binary-distribution-format/#the-data-directory

Fixes #2450

The basename of the ".data" directory in the wheel now matches the
basename of the ".dist-info" directory, as per the wheel spec[1], like
so:

     distribution-1.0.dist-info
     distribution-1.0.data

1: https://packaging.python.org/en/latest/specifications/binary-distribution-format/#the-data-directory
@ejd
Copy link
Contributor Author

ejd commented Jan 23, 2025

This PR fixes #2450

@konstin konstin merged commit 5a9b24c into PyO3:main Jan 23, 2025
39 checks passed
@ejd ejd deleted the fix-data-dir branch January 23, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.data directory in generated wheels has the wrong name
2 participants