Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.data directory in generated wheels has the wrong name #2450

Closed
1 of 2 tasks
ejd opened this issue Jan 23, 2025 · 0 comments · Fixed by #2449
Closed
1 of 2 tasks

.data directory in generated wheels has the wrong name #2450

ejd opened this issue Jan 23, 2025 · 0 comments · Fixed by #2449
Labels
bug Something isn't working

Comments

@ejd
Copy link
Contributor

ejd commented Jan 23, 2025

Bug Description

According to the wheel spec, a wheel's ".data" directory wheel should have the same basename as the ".dist-info" directory.

Currently, maturin uses distribution.data for the directory name. The name should be, for example, distribution-1.0.data.

Your maturin version (maturin --version)

1.7.8

Your Python version (python -V)

Python 3.8.19

Your pip version (pip -V)

pip 24.3.1

What bindings you're using

pyo3

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

set -eux
mkdir example
cd example
maturin init --bindings pyo3
mkdir -p example.data/data
echo "text" > example.data/data/dummy.bin
RUST_LOG=maturin=debug maturin build --color never
unzip -l target/wheels/example-0.1.0-cp38-cp38-manylinux_2_34_x86_64.whl

Output: https://gist.github.com/ejd/ed69fcf38d8b00c699ff3aebeaceb1c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant