Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug or feature ? #1631

Closed
neutrinoceros opened this issue Jan 3, 2021 · 2 comments
Closed

bug or feature ? #1631

neutrinoceros opened this issue Jan 3, 2021 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@neutrinoceros
Copy link

I'm curious if this behaviour is intended where isort doesn't reorder anything but combines comments attached to lines where I import the same module under two different names

isort --diff isort_comments.py

--- path/to/cwd/isort_comments.py:before 2021-01-03 18:20:37.072373
+++ path/to/cwd/isort_comments.py:after	2021-01-03 18:22:04.439485
@@ -1,2 +1,2 @@
-import a # a comment
-import a as b # b comment
+import a  # a comment; b comment
+import a as b  # a comment; b comment
@timothycrosley timothycrosley added the bug Something isn't working label Jan 4, 2021
@timothycrosley
Copy link
Member

This looks like a bug to me! Thanks for reporting!

@timothycrosley
Copy link
Member

This is fixed in develop and will be released in the 5.8.0 release of isort.

Thanks!

~Timothy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants