-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fragile imports #3016
Fix fragile imports #3016
Conversation
Indeed the one test that failed was the one defining a sample plugin file: it broke because |
I think able, but not likely.
…On Mon, Jan 4, 2021 at 10:55 AM Clément Robert ***@***.***> wrote:
Indeed the one test that failed was the one defining a sample plugin file:
it broke because np wasn't defined anywhere else.
I went ahead and fixed it but this *does* mean that this removal is able
to cause breakage downstream...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3016 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVXOYH4IUU2VRW22C6XT3SYHXGPANCNFSM4VSAGSWA>
.
|
Well merge away if you're up for it, but I'm adding the "backward incompatible" label for the release manager because the natural error message is really not helpful:
users should be warned that they need to import numpy themselves from the plugin file if they intend to use it there. |
PR Summary
For a while there was a note in pyproject.toml that said isort couldn't be applied to yt/init.py because it would create circular imports. Turns out there are only a handful of fragilities to fix in that regard, and I'm doing it here.