Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty line added in import that should be skipped #1548

Closed
samdaviesudina opened this issue Oct 8, 2020 · 1 comment · Fixed by hypothesis/viahtml#107 or wwade/jobrunner#63
Closed
Labels
bug Something isn't working

Comments

@samdaviesudina
Copy link

I'm seeing an issue with 5.6.0 that I wasn't seeing with 5.5.3.

Before running isort:

from tools.dependency_pruning.prune_dependencies import (  # isort:skip
    prune_dependencies,
)

After running isort:

from tools.dependency_pruning.prune_dependencies import (  # isort:skip

    prune_dependencies,
)

Config:

[isort]
profile = black
float_to_top = True

If I remove float_to_top = True from the config, the line doesn't get added anymore.

Thanks!

@timothycrosley timothycrosley added the bug Something isn't working label Oct 9, 2020
timothycrosley added a commit that referenced this issue Oct 9, 2020
…-import-skip

Fixed #1548: On rare occasions an unecessary empty line can be added …
@timothycrosley
Copy link
Member

Thanks for reporting! This has been fixed in isort 5.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants