Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty line added between imports that should be skipped #1556

Closed
samdaviesudina opened this issue Oct 12, 2020 · 1 comment · Fixed by hypothesis/viahtml#107 or wwade/jobrunner#63
Closed

Comments

@samdaviesudina
Copy link

This is very similar to #1548 , but the line now appears between imports.
I'm running v5.6.3 of isort.

Before running isort:

from tools.dependency_pruning.prune_dependencies import (  # isort:skip
    prune_dependencies,
)
from tools.developer_pruning.prune_developers import (  # isort:skip
    prune_developers,
)

After running isort:

from tools.dependency_pruning.prune_dependencies import (  # isort:skip
    prune_dependencies,
)

from tools.developer_pruning.prune_developers import (  # isort:skip
    prune_developers,
)

Config:

[isort]
profile = black
float_to_top = True

Just as it happened with #1548 , if I remove float_to_top = True then the empty line does not get added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment