Skip to content

[Feature] Complete implementation of program upgradability.#2807

Merged
vicsn merged 162 commits intostagingfrom
refresh/upgradability-after-record-migration
Jul 25, 2025
Merged

[Feature] Complete implementation of program upgradability.#2807
vicsn merged 162 commits intostagingfrom
refresh/upgradability-after-record-migration

Conversation

@d0cd
Copy link
Collaborator

@d0cd d0cd commented Jul 14, 2025

@ljedrz
Copy link
Collaborator

ljedrz commented Jul 22, 2025

note: VM::check_transaction has become very long - we might want to consider splitting it into sub-checks

Copy link
Collaborator

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM engineering-wise 👍

@d0cd d0cd requested a review from vicsn July 22, 2025 17:50
@d0cd d0cd requested a review from vicsn July 23, 2025 20:46
// If the edition is zero, then check that:
// - The program does not exist in the store or process.
// If the edition is one, then check that:
// - The program contains a constructor.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// - The program contains a constructor.
// - The program contains a constructor after `ConsensusVersion::V9`.

@raychu86
Copy link
Collaborator

Waiting on 1 change for Program Deployment defaults for checksum and owner

Copy link
Collaborator

@vicsn vicsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work everyone, and especially @d0cd . I will update the consensus heights in a follow-up PR.

@vicsn vicsn merged commit e1365a7 into staging Jul 25, 2025
2 checks passed
@vicsn vicsn deleted the refresh/upgradability-after-record-migration branch July 25, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants