[Feature] Reject old executions after an upgrade.#2722
Closed
d0cd wants to merge 8 commits intofeat/program-owner-operandfrom
Closed
[Feature] Reject old executions after an upgrade.#2722d0cd wants to merge 8 commits intofeat/program-owner-operandfrom
d0cd wants to merge 8 commits intofeat/program-owner-operandfrom
Conversation
vicsn
requested changes
May 26, 2025
vicsn
approved these changes
May 27, 2025
d0cd
force-pushed
the
feat/reject-old-execs-after-upgrade
branch
from
4a3a624 to
962d5fd
Compare
Collaborator
Author
|
Closed in favor of #2807 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[NO NEW COMMITS ARE ALLOWED AS OF 5/27/25]
THE CHANGES MADE IN THIS PR ARE REMOVED BY #2758.
This PR exists for the purpose of keeping audits consistent.
This PR rejects executions whose state roots are before the latest upgrade.
This ensures that users do not create executions for program logic that may have changed.
This does require that executions use "fresh" state roots, but the overhead should not be meaningful w.r.t to fetching state roots for records.