Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle empty username for Redis/RedisNg AUTH #170

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Correctly handle empty username for Redis/RedisNg AUTH #170

merged 1 commit into from
Dec 10, 2024

Conversation

breda
Copy link
Contributor

@breda breda commented Dec 6, 2024 •
edited
Loading

Hey! Bug issue reported here #171

This PR simply checks if the username is empty which is quite common, and if so exclude it from auth call.

@breda breda force-pushed the redis-auth-bugfix branch from 4c72235 to e9ba91c Compare December 6, 2024 09:38
@breda breda mentioned this pull request Dec 10, 2024
Closed
LKaemmerling
LKaemmerling approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@LKaemmerling LKaemmerling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@LKaemmerling LKaemmerling merged commit 3f8e4ff into PromPHP:main Dec 10, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKaemmerling LKaemmerling LKaemmerling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@breda @LKaemmerling