Correctly handle empty username for Redis/RedisNg AUTH

breda · breda · commit e9ba91ca4c7f · 2024-12-06T10:37:57.000+01:00
Signed-off-by: Reda &lt;reda.bouchaala@printify.com&gt;
diff --git a/src/Prometheus/Storage/Redis.php b/src/Prometheus/Storage/Redis.php
@@ -198,7 +198,7 @@ private function ensureOpenConnection(): void
         $this->connectToServer();
         $authParams = [];
 
-        if (isset($this->options['user'])) {
+        if (isset($this->options['user']) && $this->options['user'] !== '') {
             $authParams[] = $this->options['user'];
         }
 
diff --git a/src/Prometheus/Storage/RedisNg.php b/src/Prometheus/Storage/RedisNg.php
@@ -198,7 +198,7 @@ private function ensureOpenConnection(): void
         $this->connectToServer();
         $authParams = [];
 
-        if (isset($this->options['user'])) {
+        if (isset($this->options['user']) && $this->options['user'] !== '') {
             $authParams[] = $this->options['user'];
         }
 

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ private function ensureOpenConnection(): void`
`198`	`198`	`$this->connectToServer();`
`199`	`199`	`$authParams = [];`
`200`	`200`
`201`		`- if (isset($this->options['user'])) {`
	`201`	`+ if (isset($this->options['user']) && $this->options['user'] !== '') {`
`202`	`202`	`$authParams[] = $this->options['user'];`
`203`	`203`	`}`
`204`	`204`