Skip to content

Update dockerfile to use latest alpine image #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2025
Merged

Update dockerfile to use latest alpine image #383

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f36cf25
Update dockerfile to use latest alpine image
fbarbe00 Feb 25, 2025
9f75aec
Remove sed from README
fbarbe00 Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM alpine:3.5
FROM alpine:3.21

# Enables customized options using environment variables
ENV OSRM_BACKEND='http://localhost:5000'
Expand All @@ -13,7 +13,7 @@ RUN mkdir -p /src
COPY package.json /src

# Install app dependencies
RUN apk add --no-cache sed nodejs && \
RUN apk add --no-cache npm && \
Copy link
Member

@frodrigo frodrigo Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sed still required at this step.

Suggested change
RUN apk add --no-cache npm && \
RUN apk add --no-cache sed npm && \

Copy link
Contributor Author

@fbarbe00 fbarbe00 Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is sed used for? I just built the image without sed (exactly as it is in this version, from this branch) and everything seems to work fine.

Copy link
Member

@frodrigo frodrigo Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I see in the git history, that sed was required before, but removed, and no more required.

But the README.md also ask to install sed. I think we can also remove it fro there.

Copy link
Contributor Author

@fbarbe00 fbarbe00 Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just pushed a change

cd /src && \
npm install

Expand Down