Update dockerfile to use latest alpine image #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes unnecessary app dependency
frodrigo
reviewed
Feb 25, 2025
|
|
||
| # Install app dependencies | ||
| RUN apk add --no-cache sed nodejs && \ | ||
| RUN apk add --no-cache npm && \ |
There was a problem hiding this comment.
sed still required at this step.
Suggested change
| RUN apk add --no-cache npm && \ | |
| RUN apk add --no-cache sed npm && \ |
There was a problem hiding this comment.
What is sed used for? I just built the image without sed (exactly as it is in this version, from this branch) and everything seems to work fine.
There was a problem hiding this comment.
Ok. I see in the git history, that sed was required before, but removed, and no more required.
But the README.md also ask to install sed. I think we can also remove it fro there.
There was a problem hiding this comment.
just pushed a change
This was referenced Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes unnecessary app dependency