fix: update hami commit - #109
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
🚧 Files skipped from review as they are similar to previous changes (10)
📝 WalkthroughWalkthroughThe PR updates Go and golangci-lint tooling, refreshes module versions, changes device registration and allocation handling, and makes cleanup error discards explicit across monitoring and server utilities. ChangesTooling and module updates
Server and cleanup updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant PluginServer
participant DeviceManager
participant HAMiAPI
PluginServer->>DeviceManager: Get Ascend910 network ID
DeviceManager-->>PluginServer: Return NetworkID
PluginServer->>HAMiAPI: Send JSON-marshaled device payload
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5d8b92f to
4fbc07b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 47: Update the golangci-lint configuration to the v2 schema before
retaining the v2.0.2 CI version, migrating exclusion settings under
linters.exclusions.* and formatter configuration to formatters.enable so
golangci-lint config verify succeeds.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 99924dd4-50c9-4a1c-8c49-44a72b48da51
📒 Files selected for processing (2)
.github/workflows/ci.ymlgo.mod
1469544 to
974a9d2
Compare
36eafff to
f08c1b3
Compare
5fd7b8f to
14e2395
Compare
1873624 to
0937342
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.golangci.yml:
- Around line 1-21: Update the Makefile’s golangci-lint installation pin from
v1.61.0 to a compatible v2.x release, so make lint can parse the version 2
configuration in .golangci.yml and remains aligned with CI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ba4319fc-6725-492a-a34d-e89ae1ffaa42
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (11)
.github/workflows/ci.yml.golangci.ymlgo.modinternal/monitor/container.gointernal/monitor/registry.gointernal/server/allocate.gointernal/server/register.gointernal/server/server.gointernal/server/server_test.gointernal/server/util.gointernal/wachers.go
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/ci.yml
d1fb395 to
c8f8a88
Compare
Signed-off-by: james <open4pd@4paradigm.com>
Signed-off-by: james <open4pd@4paradigm.com>
Signed-off-by: james <open4pd@4paradigm.com>
Signed-off-by: james <open4pd@4paradigm.com>
c8f8a88 to
7f8ac79
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: archlitchi, DSFans2014 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When using HAMi vNPU with Volcano and enabling node lock, the node lock value stored in Volcano is a timestamp. However, the ReleaseNodeLock function called in ascend-device-plugin expects the lock value to contain the pod's namespace and name. Since the timestamp format does not match the lock is never released.
this problem has been fixed in Project-HAMi/HAMi#2054
the main changes as below:
Error return value of xxx is not checkedlint errorjson.Marshalto encode the device directly as the implement ofMarshalNodeDevicesis changedgolangci-lintand change the related confSummary by CodeRabbit
Summary by CodeRabbit
Chores
golangci-lintand the workflow/action versions).Bug Fixes