fix: skip owner check for legacy lock format

[DSFans2014]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When using HAMi vNPU with Volcano and enabling node lock, the node lock value stored in Volcano is a timestamp. However, the ReleaseNodeLock function called in ascend-device-plugin expects the lock value to contain the pod's namespace and name. Since the timestamp format does not match the lock is never released.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Summary by CodeRabbit

• Bug Fixes
  • Fixed node lock release handling for legacy timestamp-only annotation values, allowing locks to be released when the stored format is older than the current one.
• Tests
  • Expanded node lock release test coverage with new cases for legacy-format locks and additional post-release verification that the lock annotation is removed.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d48cebb-d1d7-4dd3-8880-b1e74b36986d

📥 Commits

Reviewing files that changed from the base of the PR and between 62a0bbf and dc7d08f.

📒 Files selected for processing (2)

• pkg/util/nodelock/nodelock.go
• pkg/util/nodelock/nodelock_test.go

🚧 Files skipped from review as they are similar to previous changes (2)

• pkg/util/nodelock/nodelock_test.go
• pkg/util/nodelock/nodelock.go

---

📝 Walkthrough

Walkthrough

ReleaseNodeLock now releases legacy timestamp-only node-lock annotations while retaining ownership checks for current formatted values. TestReleaseNodeLock verifies annotation removal for successful releases, including the legacy format.

Changes

Node Lock Release

Layer / File(s)	Summary
Legacy lock release compatibility pkg/util/nodelock/nodelock.go, pkg/util/nodelock/nodelock_test.go	ReleaseNodeLock bypasses the suffix-based ownership check for timestamp-only legacy values, while tests verify successful release and removal of the lock annotation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit found an old lock in the hay,
Its timestamp still marked the way.
“No suffix?” it cheered,
The lock disappeared,
And tests hopped happily away.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: bypassing the owner check for legacy node-lock format.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Code Review

This pull request introduces backward compatibility for the legacy node lock format (a simple timestamp) by checking if the lock string contains the separator before validating the owner. A corresponding unit test has been added to verify this behavior. The reviewer suggested improving performance and readability by replacing fmt.Sprintf with direct string concatenation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
unittests	59.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/util/nodelock/nodelock.go	68.18% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mesutoezdil]

first commit message uses feat: but this is a bug fix, it should be fix: to match the pr title and conventional commits.

[mesutoezdil]

/lgtm

[archlitchi]

/lgtm

[hami-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, DSFans2014

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [DSFans2014,archlitchi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment