Skip to content

[Ascend] Requests-only pods skip memory validation, so an over-capacity request #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xiaoyaoqilan wants to merge 1 commit into from
Closed

[Ascend] Requests-only pods skip memory validation, so an over-capacity request #2538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/develop/design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The architecture of HAMi is shown in the figure above. It is organized in the fo

- MutatingWebhook

The MutatingWebhook checks the validity of each task, and set the "schedulerName" to "HAMi scheduler" if the resource requests have been recognized by HAMi
The MutatingWebhook checks the validity of each task, and set the "schedulerName" to "HAMi scheduler" if the resource limits have been recognized by HAMi

@coderabbitai coderabbitai Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Fix the verb agreement.

Change and set to and sets.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/develop/design.md` at line 9, Update the sentence describing
MutatingWebhook so the verb agrees with the singular subject: replace “and set”
with “and sets,” preserving the rest of the wording.

If Not, the MutatingWebhook does nothing and pass this task to default-scheduler.

- Scheduler
Expand Down
Loading