[Ascend] Requests-only pods skip memory validation, so an over-capacity request

[xiaoyaoqilan]

This PR fixes the documentation issue reported in #2532: corrects requests to limits in docs/develop/design.md.

Fixes #2532

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes #2532

Summary by CodeRabbit

• Documentation
  • Corrected the MutatingWebhook documentation to clarify that resource limits determine HAMi scheduler assignment.

[hami-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaoyaoqilan
Once this PR has been reviewed and has the lgtm label, please assign dsfans2014 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hami-robot]

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

• dd33b10 [Ascend] Requests-only pods skip memory validation, so an over-capacity request

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[hami-robot]

Welcome @xiaoyaoqilan! It looks like this is your first PR to Project-HAMi/HAMi 🎉

[coderabbitai]

📝 Walkthrough

Walkthrough

The design documentation updates the MutatingWebhook condition from resource requests to resource limits when assigning the HAMi scheduler.

Changes

MutatingWebhook documentation

Layer / File(s)	Summary
Update scheduler assignment condition docs/develop/design.md	The MutatingWebhook description now states that resource limits trigger assignment of the HAMi scheduler.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A rabbit reads the webhook line,
“Limits,” it says, “now reads just fine.”
The scheduler name hops into place,
With tidy docs and smiling face.
Carrots celebrate the change.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The pull request changes documentation only and does not implement validation fixes or regression tests required by issue #2532.	Implement validation for both limits and requests paths, and add regression coverage for over-capacity Ascend memory requests.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately identifies the Ascend requests-only memory-validation issue addressed by the pull request.
Out of Scope Changes check	✅ Passed	The documentation correction is related to the linked Ascend memory-validation issue, and no unrelated code changes are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/develop/design.md`:
- Line 9: Update the sentence describing MutatingWebhook so the verb agrees with
the singular subject: replace “and set” with “and sets,” preserving the rest of
the wording.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ed498ae5-a44e-45c3-bd4b-8cbb47667201

📥 Commits

Reviewing files that changed from the base of the PR and between 8812b79 and dd33b10.

📒 Files selected for processing (1)

• docs/develop/design.md

[coderabbitai]

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Fix the verb agreement.

Change and set to and sets.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/develop/design.md` at line 9, Update the sentence describing
MutatingWebhook so the verb agrees with the singular subject: replace “and set”
with “and sets,” preserving the rest of the wording.

[mesutoezdil]

You can view the relevant rule here.
https://github.com/Project-HAMi/HAMi/blob/master/CONTRIBUTING.md#contribution-gates