Skip to content

Remove postStart hook for hami-core-vNPU tasks #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hami-robot merged 10 commits into from
Jul 15, 2026
Merged

Remove postStart hook for hami-core-vNPU tasks #2062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bcad689
remove dra from charts
archlitchi Jul 9, 2026
8549b96
Merge branch 'Project-HAMi:master' into master
archlitchi Jul 9, 2026
30b8fe3
update chart
archlitchi Jul 9, 2026
91bace5
Merge branch 'Project-HAMi:master' into master
archlitchi Jul 10, 2026
6884631
remote deleted annotations
archlitchi Jul 10, 2026
a5b3c72
fix go-lint
archlitchi Jul 10, 2026
26819b5
fix go-lint
archlitchi Jul 10, 2026
19a0d1d
update
archlitchi Jul 10, 2026
5108983
Merge branch 'Project-HAMi:master' into master
archlitchi Jul 13, 2026
fc2572a
remove postStartHook for vNPU
archlitchi Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions pkg/device/ascend/device.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,27 +161,6 @@ func (dev *Devices) MutateAdmission(ctr *corev1.Container, p *corev1.Pod) (bool,
}
}

if isHAMiCore {
klog.V(3).Infof("Ascend core resource detected, injecting postStart lifecycle for container %s", ctr.Name)

if ctr.Lifecycle == nil {
ctr.Lifecycle = &corev1.Lifecycle{}
}

// Inject PostStart hook to start the limiter process
if ctr.Lifecycle.PostStart == nil {
ctr.Lifecycle.PostStart = &corev1.LifecycleHandler{
Exec: &corev1.ExecAction{
Command: []string{
"bash",
"-c",
"export RUST_LOG=info\n/hami-vnpu-core/limiter > /tmp/limiter_manager.log 2>&1 &",
},
},
}
}
}

trimMem := dev.config.MemoryAllocatable
memory, ok := ctr.Resources.Limits[corev1.ResourceName(dev.config.ResourceMemoryName)]
if ok {
Expand Down
14 changes: 6 additions & 8 deletions pkg/device/ascend/device_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,7 +856,7 @@ func Test_MutateAdmission_VNPUCoreMode(t *testing.T) {
wantCore int64
}{
{
name: "vNPU-mode hami-core: inject postStart and keep raw memory",
name: "vNPU-mode hami-core: keep raw memory without postStart",
args: struct {
ctr corev1.Container
pod corev1.Pod
Expand Down Expand Up @@ -884,7 +884,7 @@ func Test_MutateAdmission_VNPUCoreMode(t *testing.T) {
},
},
},
wantPostStart: true,
wantPostStart: false,
wantMem: 15360,
wantCore: 20,
},
Expand All @@ -906,12 +906,10 @@ func Test_MutateAdmission_VNPUCoreMode(t *testing.T) {
assert.NilError(t, err)
assert.Equal(t, ok, true)

if test.wantPostStart {
assert.Assert(t, test.args.ctr.Lifecycle != nil, "Lifecycle should not be nil")
assert.Assert(t, test.args.ctr.Lifecycle.PostStart != nil, "PostStart should not be nil")
assert.Assert(t, test.args.ctr.Lifecycle.PostStart.Exec != nil)
commandStr := strings.Join(test.args.ctr.Lifecycle.PostStart.Exec.Command, " ")
assert.Assert(t, strings.Contains(commandStr, "/hami-vnpu-core/limiter"))
if !test.wantPostStart {
if test.args.ctr.Lifecycle != nil {
assert.Assert(t, test.args.ctr.Lifecycle.PostStart == nil, "PostStart should not be set")
}
}
Comment thread
archlitchi marked this conversation as resolved.

memLimit := test.args.ctr.Resources.Limits[corev1.ResourceName(dev.config.ResourceMemoryName)]
Expand Down
Loading