Remove postStart hook for hami-core-vNPU tasks

[archlitchi]

/kind cleanup

Limiter process will be automatically launched when accessing cann API, we don't need to manually launch it anymore

Summary by CodeRabbit

• Bug Fixes
  • Updated hami-core admission behavior to stop adding an automatic container startup hook.
  • Preserved raw memory allocation handling during vNPU-mode admission.
• Tests
  • Updated admission tests to verify that no startup hook is added in hami-core mode.

[archlitchi]

CC @Shouren

[wawa0210]

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

---

cc @s descendants

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 55011736-d637-4224-8f10-6971861452d3

📥 Commits

Reviewing files that changed from the base of the PR and between a1b418c and fc2572a.

📒 Files selected for processing (2)

• pkg/device/ascend/device.go
• pkg/device/ascend/device_test.go

💤 Files with no reviewable changes (1)

• pkg/device/ascend/device.go

---

📝 Walkthrough

Walkthrough

hami-core admission no longer injects a limiter postStart hook. VNPU core-mode tests now verify that the lifecycle hook is absent while raw memory handling remains unchanged.

Changes

hami-core admission behavior

Layer / File(s)	Summary
Remove limiter lifecycle hook and update tests pkg/device/ascend/device.go, pkg/device/ascend/device_test.go	Admission skips postStart injection, and VNPU core-mode tests expect no lifecycle hook while preserving raw memory.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A bunny saw the hook hop away,
While raw memory stayed in play.
No limiter starts at pod birth,
Tests guard the change with cheerful mirth.
Hop, hop—clean admission today!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the postStart hook for hami-core vNPU tasks.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Code Review

This pull request removes the injection of the PostStart lifecycle hook for Ascend core resources in MutateAdmission and updates the corresponding unit tests. The reviewer suggests simplifying the test assertions to directly verify that the container's Lifecycle remains nil, rather than using redundant nested conditional checks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
unittests	59.71% <ø> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/device/ascend/device.go	83.41% <ø> (-0.50%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Shouren]

/lgtm

[hami-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archlitchi, Shouren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Shouren,archlitchi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Shouren]

@archlitchi It seems that the doc about limiter-process-startup is out of date.