docs: add contribution gates to AI assistance policy - #2019
Conversation
📝 WalkthroughWalkthroughCONTRIBUTING.md now includes a table of contents entry and a new “Contribution Gates” section with six contributor rules covering author understanding, hardware validation, scope and commit-message limits, review reply authorship, commit trailer hygiene, and AI-generated review-comment restrictions. ChangesContribution Gates documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request updates CONTRIBUTING.md to add a 'Contribution Gates' section containing six rules regarding author understanding, hardware validation, scope/commit messages, review replies, commit trailer hygiene, and AI-generated comments. The review feedback highlights ambiguities in rule 3 (clarifying if the issue and commit-splitting requirements apply to all contributions or only AI-assisted ones) and rule 6 (refining the exception criteria for AI-generated comments to make it more objective and actionable).
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
CONTRIBUTING.md (1)
79-89: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winTighten the gate language so it’s enforceable.
"closed","small fix","reviewable commits", and"critical and clearly your own assessment"are still subjective, so this will be hard to apply consistently. If scheduling decisions are meant to be in scope too, say that explicitly in rule 2.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CONTRIBUTING.md` around lines 79 - 89, Tighten the policy wording in CONTRIBUTING so the enforcement criteria are less subjective: revise the author-understanding, scope, commit-message, and AI-generated-comment rules to use clearer, actionable language, and make sure the terms around closure, small fixes, reviewable commits, and acceptable exceptions are defined consistently. Also update the hardware validation rule to explicitly state whether scheduling decisions are included in scope, so the rule is unambiguous when applied to changes in the scheduler-related guidance.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@CONTRIBUTING.md`:
- Around line 79-89: Tighten the policy wording in CONTRIBUTING so the
enforcement criteria are less subjective: revise the author-understanding,
scope, commit-message, and AI-generated-comment rules to use clearer, actionable
language, and make sure the terms around closure, small fixes, reviewable
commits, and acceptable exceptions are defined consistently. Also update the
hardware validation rule to explicitly state whether scheduling decisions are
included in scope, so the rule is unambiguous when applied to changes in the
scheduler-related guidance.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 714ecc9a-9bed-4d3f-bd64-3b4a74dd4739
📒 Files selected for processing (1)
CONTRIBUTING.md
Adds six enforceable rules to CONTRIBUTING.md based on maintainer feedback in Project-HAMi#1998. - Author-understanding gate with stated consequence - Hardware validation for device/isolation changes; scheduler extender exempt per Shouren's feedback - Scope and commit message rules for AI-assisted contributions - Review reply requirements - Commit trailer hygiene - AI-generated comment policy per archlitchi's feedback Rules 6-8 from the original proposal are deferred. Closes Project-HAMi#1998 Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
74839af to
4589ac7
Compare
Ports the contribution gates from Project-HAMi/HAMi#2019 to HAMi-core. The hardware validation rule is kept without the scheduler extender exception since HAMi-core has no scheduler component. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
|
I agree that AI should be limited and encouraged to be used reasonably. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mesutoezdil, Shouren The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds six enforceable contribution gates to the AI Assistance section of
CONTRIBUTING.md, based on maintainer discussion in #1998.The existing notice is kept unchanged. The new gates cover:
Rule 2 is scoped per @Shouren's feedback (#1998 (comment)): scheduler extender changes do not require real GPU hardware.
Rule 6 is added per @archlitchi's feedback (#1998 (comment)).
Rules 6-8 from the original proposal are deferred pending further discussion.
Does this PR introduce a user-facing change?
No.
Closes #1998
Summary by CodeRabbit