docs(CONTRIBUTING): add guideline to separate cosmetics from function… - #1995
Conversation
…al commits Inspired by FFmpeg code-review practices, this rule keeps diffs reviewable by requiring cosmetic changes to be in their own commits. Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single documentation line was added to CONTRIBUTING.md's Code Review section, advising contributors to separate cosmetic changes from functional logic changes and to split them into separate commits or PRs. ChangesDocumentation update
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the CONTRIBUTING.md file to add a guideline advising contributors to separate cosmetic changes from functional changes to keep diffs reviewable. The feedback suggests a minor grammatical correction to ensure plural agreement in the newly added text.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: archlitchi, fishman, saiyam1814 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…al commits
Inspired by FFmpeg code-review practices, this rule keeps diffs reviewable by requiring cosmetic changes to be in their own commits.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
In general this is good practice, but beyond that it catches a lot of cases where AI generated code edits and beautifies comments.
Summary by CodeRabbit