Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing error in loader function #122

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

extremeheat
Copy link
Member

@extremeheat extremeheat commented Jan 11, 2025

Fixes #111

Update the loader function in index.d.ts to accept either a string mcVersion or a bot.registry object.

  • Modify the TypeScript definition to reflect the possible bot.registry parameter.

For more details, open the Copilot Workspace session.

Fixes #111

Update the `loader` function in `index.d.ts` to accept either a string `mcVersion` or a `bot.registry` object.

* Modify the TypeScript definition to reflect the possible `bot.registry` parameter.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/PrismarineJS/prismarine-item/issues/111?shareId=XXXX-XXXX-XXXX-XXXX).
@rom1504 rom1504 merged commit 7d4cd63 into master Jan 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type error: loader(mcVersion) it's not only string
2 participants