Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type error: loader(mcVersion) it's not only string #111

Closed
AugustinMauroy opened this issue Aug 23, 2023 · 0 comments · Fixed by #122
Closed

type error: loader(mcVersion) it's not only string #111

AugustinMauroy opened this issue Aug 23, 2023 · 0 comments · Fixed by #122

Comments

@AugustinMauroy
Copy link

prismarine-item/index.d.ts

Line 43 in 690d640

export default function loader(mcVersion: string): typeof Item;

on this there are an typing error because it's can also an bot.registery like this:

(mineflayer/lib/plugins/anvil.js)[https://github.com/PrismarineJS/mineflayer/blob/d3df34dcaa804a71bf0d8cc50a419990d4a2dce3/lib/plugins/anvil.js#L8]
extremeheat added a commit that referenced this issue Jan 11, 2025
@extremeheat
Fix typing error in loader function
454e180 
Fixes #111

Update the `loader` function in `index.d.ts` to accept either a string `mcVersion` or a `bot.registry` object.

* Modify the TypeScript definition to reflect the possible `bot.registry` parameter.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/PrismarineJS/prismarine-item/issues/111?shareId=XXXX-XXXX-XXXX-XXXX).
@extremeheat extremeheat mentioned this issue Jan 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typing error in loader function PrismarineJS/prismarine-item
1 participant
@AugustinMauroy