-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Scala keywords to support Scala 3 #3506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
Please add the new keywords to Scala's keyword test and update the test. And please rebuild Prism by running npm ci && npm run build
(the prism-scala.min.js
file needs to be committed).
Thank you @RunDevelopment for your help. I’ve added a test but I was unable to update the test:
Maybe my version of node is too old? I use version 14.20.0, which should be OK according to your README? Running
I am not sure how to move forward. |
Add `given`, `transparent`, and `using` keywords.
No, NodeJS v14.x is supported. We use that version is our CI. Are you sure you installed our dependencies correctly? Please use |
I did |
That is very strange. My only guess is that npm is not actually using node to run our tests and build scripts. We recently had a similar issue. For now, I rebuilt and updated the tests for you. |
Thank you! |
Add several soft keywords that have been introduced in Scala 3.