-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bash: Added support for parameters and the java
and sysctl
commands.
#3505
Conversation
1. `|sysctl|` 2. the docker functions: `|docker|` -> `docker(\s+(run|start|stop|restart|kill|rm|pause|unpause|create|exec|ps|inspect|top|attach|events|logs|wait|export|port|commit|cp|diff|login|pull|push|search|images|rmi|tag|build|history|save|load|import|info|version))?|`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @wangliang181230!
I left you a comment on the assignment token. The addition of sysctl
is fine.
However, the docker command additions are incorrect. docker run
is not a command. docker
is a command and run
is just a parameter (that docker just so happens to interpret as a sub command). So while the highlighting might be visually pleasing, I think it is incorrect and should be removed.
Also, please add update the tests. We have over a thousand test files and some of them changed. Please run npm run test:languages -- --update
to update them all.
Ok, i will remove the docker command.
Ok. |
Suggested change. Co-authored-by: Michael Schmidt <[email protected]>
remove docker commands.
sysctl
sysctl
sysctl
and java
sysctl
and java
sysctl
and java
, support parameter
sysctl
and java
, support parameter
sysctl
and java
, support parameter
sysctl
and java
, support parameter
java
and sysctl
, support parameter
Also, please create a test case for the new |
Suggested change. Co-authored-by: Michael Schmidt <[email protected]>
Thank you @wangliang181230! To make the CI pass, please run |
java
and sysctl
, support parameter
parameter
, add functions java
and sysctl
.
npm told you the problem:
What's this strange node program you're using? |
done. |
That didn't work. You might have accidentally installed the wrong uglify version. Could you try running |
PS E:\Workspace_Java\wangliang181230\prism> npm version
{
prismjs: '1.28.0',
npm: '6.14.6',
ares: '1.16.0',
brotli: '1.0.7',
http_parser: '2.9.3',
llhttp: '2.1.2',
modules: '72',
napi: '6',
nghttp2: '1.41.0',
node: '12.18.4',
openssl: '1.1.1g',
uv: '1.38.0',
v8: '7.8.279.23-node.39',
zlib: '1.2.11'
}
|
@RunDevelopment |
Thank you for contributing @wangliang181230! |
parameter
, add functions java
and sysctl
.java
and sysctl
commands.
Added support for parameters:
-key
-key
=value--key
--key
=value--aaa.key
--aaa.key
=value-XX:xxxxx
-XX:xxxxx
=value-XX:+xxxxx
-XX:+xxxxx
=value-XX:-xxxxx
-XX:-xxxxx
=valueAdded more commands:
java
sysctl
Optimize assign-left:
aaa.bbb
=111Display effect: