Skip to content

Revert "Use native JSON bytes for upstream eval traffic" - #1800

Merged
xeophon merged 1 commit into
feat/nano-as-v1from
revert-1798-codex/v1-native-json-upstream
Jun 21, 2026
Merged

Revert "Use native JSON bytes for upstream eval traffic"#1800
xeophon merged 1 commit into
feat/nano-as-v1from
revert-1798-codex/v1-native-json-upstream

Conversation

@xeophon

@xeophon xeophon commented Jun 21, 2026

Copy link
Copy Markdown
Member

Reverts #1798


Note

Medium Risk
Changes how all upstream eval bodies are encoded and parsed, which can differ from the reverted path on edge cases (non-finite floats, JSON wire shape) even though it restores prior behavior.

Overview
Reverts the native JSON bytes path in EvalClient and restores httpx’s built-in JSON for upstream eval and aux relays.

_request again uses build_request(..., json=body) instead of manually serializing with pydantic_core.to_json, setting content-type, and walking the body to reject non-finite floats. Response handling switches from from_json(resp.content) back to resp.json() in get_response and relay_aux. Unused math and pydantic_core imports are removed.

Reviewed by Cursor Bugbot for commit e0552d4. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Revert native JSON serialization in EvalClient to use httpx defaults

Reverts the EvalClient in eval.py to use httpx's built-in JSON handling instead of pydantic_core. Removes manual pre-validation of non-finite floats and explicit content-type headers, replacing pydantic_core.to_json/from_json calls with json=body and resp.json() throughout. Risk: non-finite float values (e.g. NaN, Infinity) in request bodies are no longer rejected before serialization.

Macroscope summarized e0552d4.

@xeophon
xeophon merged commit 4117896 into feat/nano-as-v1 Jun 21, 2026
5 checks passed
@macroscopeapp

macroscopeapp Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This revert removes a recent JSON serialization optimization and returns to httpx's standard built-in JSON handling. The changes are mechanical and restore previously working behavior.

You can customize Macroscope's approvability policy. Learn more.

pull Bot pushed a commit to Stars1233/verifiers that referenced this pull request Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant