docs(dynamo): add training recipes - #3180
Open
biswapanda wants to merge 3 commits into
Open
Conversation
biswapanda
marked this pull request as ready for review
August 3, 2026 21:44
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency
dynamo_discovery_urlconsumed by these recipesThis branch includes the prerequisite commit so the examples remain configuration-valid while targeting
main.Test plan
ruff checkon the combined changed surfaceNote
Medium Risk
Changes weight-broadcast topology validation and NCCL initialization paths for external inference; misconfigured
inference_world_sizeor discovery could deadlock or skip broadcasts, but scope is additive behinddynamo_discovery_url.Overview
Adds external Dynamo inference support so Prime can train against a separately managed Dynamo/vLLM stack without launching
[inference].Runtime & config: Orchestrator clients can set
dynamo_discovery_url(mutually exclusive withadmin_base_urland elastic DNS). A newDynamoInferencePoolpolls/v1/rl/workers, validates worker snapshots, and wires per-engine admin URLs for weight updates. Sharedweight_broadcast.inference_world_sizeis required for Dynamo orchestrator configs and is propagated through RL resolution so NCCL/NIXL (and filesystem for LoRA) know how many inference ranks to expect; single-node NCCL no longer demands two local GPUs when that external world size is set explicitly.Docs/examples:
examples/dynamo/documents the K8s/env overlay (RL ports, sidecarPOD_IP, NCCL worker extension) and adds smoke recipes for Qwen3-0.6B math, Qwen3-30B Thinking (1P/1D), and multi-node GLM-5.2 FP8 R2E with split trainer/orchestrator TOMLs.Reviewed by Cursor Bugbot for commit 2f67c72. Bugbot is set up for automated code reviews on this repo. Configure here.