[DYNAMO] feat(helm): tolerations, imagePullSecrets, configMap mount - #2393
Closed
AmeenP wants to merge 1 commit into
Closed
[DYNAMO] feat(helm): tolerations, imagePullSecrets, configMap mount#2393AmeenP wants to merge 1 commit into
AmeenP wants to merge 1 commit into
Conversation
Adds three commonly-needed knobs to the prime-rl Helm chart, gated so defaults are byte-identical to before: - `<component>.tolerations` on orchestrator/inference/trainer for scheduling onto tainted nodes (e.g. dedicated GPU pools). - `<component>.imagePullSecrets` so private-registry images can be pulled without baking secrets into the cluster's default service account. - `orchestrator.configMap` mounts an existing ConfigMap at /configs in the orchestrator container, so TOML configs can be shipped without rebuilding the image. Also quotes the `command` arg in autoStart mode so multi-line shell strings don't break YAML parsing. The orchestrator's `volumeMounts` / `volumes` blocks are now gated on `storage.enabled OR configMap` so we don't emit empty lists when both are off.
AmeenP
force-pushed
the
feat/helm-deployment-options
branch
from
May 8, 2026 10:03
3c5ed0c to
1c48fa5
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three commonly-needed knobs to the prime-rl Helm chart, all opt-in. Verified with
helm template: rendered output is byte-identical to current main when defaults are used.<component>.tolerationson orchestrator / inference / trainer — schedule onto tainted nodes (dedicated GPU pools, spot/preemptible nodes, etc.) without forking the chart.<component>.imagePullSecretsso private-registry images can be pulled without baking secrets into the namespace's default ServiceAccount.orchestrator.configMapmounts an existing ConfigMap at/configsin the orchestrator container, so TOML configs can be shipped without rebuilding the image.Also quotes the
commandarg inautoStartmode so multi-line shell strings don't break YAML parsing — this was a bug waiting to happen.The orchestrator's
volumeMounts/volumesblocks are now gated onstorage.enabled OR configMapso we don't emit empty lists when both are off (the naive version would rendervolumes:with no items, which kubectl rejects).Verification