Skip to content

chore(configs): remove empty *ExperimentalConfig placeholders #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hallerite merged 1 commit into from
Jul 2, 2026
Merged

chore(configs): remove empty *ExperimentalConfig placeholders #2931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/prime-rl-configs/src/prime_rl/configs/inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,10 +337,6 @@ def validate_replicas_divide_nodes(self):
]


class InferenceExperimentalConfig(BaseConfig):
pass


class InferenceConfig(BaseConfig):
server: ServerConfig = ServerConfig()

Expand Down Expand Up @@ -436,8 +432,6 @@ class InferenceConfig(BaseConfig):
dry_run: bool = False
"""Only validate and dump resolved configs, then exit early."""

experimental: InferenceExperimentalConfig = InferenceExperimentalConfig()
Comment thread
hallerite marked this conversation as resolved.
Resolved

@model_validator(mode="after")
def validate_multi_node_requires_slurm(self):
if self.deployment.type in ("multi_node", "disaggregated") and self.slurm is None:
Expand Down
6 changes: 0 additions & 6 deletions packages/prime-rl-configs/src/prime_rl/configs/orchestrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,10 +443,6 @@ class NCCLWeightBroadcastConfig(BaseConfig):
]


class OrchestratorExperimentalConfig(BaseConfig):
pass


class OrchestratorConfig(BaseConfig):
algo: AlgoConfig = GRPOAlgoConfig()
"""Training algorithm: sampling plus the per-token training signal (credit
Expand Down Expand Up @@ -563,8 +559,6 @@ class OrchestratorConfig(BaseConfig):
heartbeat: HeartbeatConfig | None = None
"""BetterStack heartbeat configuration for monitoring training progress."""

experimental: OrchestratorExperimentalConfig = OrchestratorExperimentalConfig()

@model_validator(mode="before")
@classmethod
def _env_to_train(cls, data: Any) -> Any:
Expand Down
6 changes: 0 additions & 6 deletions packages/prime-rl-configs/src/prime_rl/configs/rl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@
)


class RLExperimentalConfig(BaseConfig):
pass


class SharedLogConfig(BaseConfig):
level: str | None = None
"""Log level for trainer, orchestrator, and inference. When unset, each sub-config's own log level applies (defaults to ``$PRIME_LOG_LEVEL`` if set, else ``info``)."""
Expand Down Expand Up @@ -234,8 +230,6 @@ class RLConfig(BaseConfig):
dry_run: bool = False
"""Only validate and dump resolved configs, then exit early."""

experimental: RLExperimentalConfig = RLExperimentalConfig()

### Validate configs (e.g. raise for unsupported (combinations of) configs)

@model_validator(mode="after")
Expand Down
6 changes: 0 additions & 6 deletions packages/prime-rl-configs/src/prime_rl/configs/sft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,6 @@ class MultiNodeDeploymentConfig(BaseDeploymentConfig):
]


class SFTExperimentalConfig(BaseConfig):
pass


class SFTConfig(BaseConfig):
model: ModelConfig = ModelConfig()

Expand Down Expand Up @@ -243,8 +239,6 @@ class SFTConfig(BaseConfig):
dry_run: bool = False
"""Only validate and dump resolved configs, then exit early."""

experimental: SFTExperimentalConfig = SFTExperimentalConfig()

### Pre-validation normalization

@model_validator(mode="before")
Expand Down
Loading