Skip to content

chore(configs): remove empty *ExperimentalConfig placeholders - #2931

Merged
hallerite merged 1 commit into
mainfrom
chore/remove-empty-experimental-configs
Jul 2, 2026
Merged

hallerite merged 1 commit into
mainfrom
chore/remove-empty-experimental-configs

Conversation

@hallerite

@hallerite hallerite commented Jul 1, 2026

Copy link
Copy Markdown
Member

Summary

Deletes the four empty *ExperimentalConfig models (pass bodies) and their experimental fields from the inference, orchestrator, rl, and sft configs — 24 dead lines.

Repo-wide grep finds no reader of any .experimental attribute and no TOML setting one. Since the models are empty and BaseConfig uses extra="forbid", no key could ever be set under them; the only expressible usage was an empty [experimental] table. A future experimental namespace can be re-added together with its first real field.

Test plan

  • uv run pytest tests/unit/test_configs.py — 114 passed

🤖 Generated with Claude Code


Note

Low Risk
Schema-only cleanup with no runtime logic changes; the only user impact is TOMLs that still include [experimental], which will error on load.

Overview
Removes four no-op *ExperimentalConfig Pydantic models and their experimental fields from InferenceConfig, OrchestratorConfig, RLConfig, and SFTConfig.

Those blocks were empty (pass only) and unused in code or TOML; with extra="forbid", they could not hold future keys anyway. Breaking for configs that still declare an [experimental] table (including empty ones): validation will now reject that section, consistent with the earlier TrainerExperimentalConfig removal.

Reviewed by Cursor Bugbot for commit 5513cd3. Bugbot is set up for automated code reviews on this repo. Configure here.

@hallerite
hallerite marked this pull request as ready for review July 1, 2026 23:47
InferenceExperimentalConfig, OrchestratorExperimentalConfig,
RLExperimentalConfig, and SFTExperimentalConfig are all empty (pass)
models wired into experimental fields that nothing reads; with
extra="forbid" they cannot even hold keys.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@hallerite
hallerite force-pushed the chore/remove-empty-experimental-configs branch from 9bef276 to 5513cd3 Compare July 1, 2026 23:49

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5513cd3. Configure here.

Comment thread packages/prime-rl-configs/src/prime_rl/configs/inference.py
@hallerite
hallerite merged commit d5f218f into main Jul 2, 2026
18 checks passed
@hallerite
hallerite deleted the chore/remove-empty-experimental-configs branch July 2, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants