chore(configs): remove empty *ExperimentalConfig placeholders - #2931
Merged
Merged
Conversation
hallerite
marked this pull request as ready for review
July 1, 2026 23:47
InferenceExperimentalConfig, OrchestratorExperimentalConfig, RLExperimentalConfig, and SFTExperimentalConfig are all empty (pass) models wired into experimental fields that nothing reads; with extra="forbid" they cannot even hold keys. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hallerite
force-pushed
the
chore/remove-empty-experimental-configs
branch
from
July 1, 2026 23:49
9bef276 to
5513cd3
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5513cd3. Configure here.
samsja
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Deletes the four empty
*ExperimentalConfigmodels (passbodies) and theirexperimentalfields from theinference,orchestrator,rl, andsftconfigs — 24 dead lines.Repo-wide grep finds no reader of any
.experimentalattribute and no TOML setting one. Since the models are empty andBaseConfigusesextra="forbid", no key could ever be set under them; the only expressible usage was an empty[experimental]table. A future experimental namespace can be re-added together with its first real field.Test plan
uv run pytest tests/unit/test_configs.py— 114 passed🤖 Generated with Claude Code
Note
Low Risk
Schema-only cleanup with no runtime logic changes; the only user impact is TOMLs that still include
[experimental], which will error on load.Overview
Removes four no-op
*ExperimentalConfigPydantic models and theirexperimentalfields fromInferenceConfig,OrchestratorConfig,RLConfig, andSFTConfig.Those blocks were empty (
passonly) and unused in code or TOML; withextra="forbid", they could not hold future keys anyway. Breaking for configs that still declare an[experimental]table (including empty ones): validation will now reject that section, consistent with the earlierTrainerExperimentalConfigremoval.Reviewed by Cursor Bugbot for commit 5513cd3. Bugbot is set up for automated code reviews on this repo. Configure here.