Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WaterdogPE xuid and IP #1356

Merged
merged 6 commits into from
Jul 3, 2022

Conversation

funniray
Copy link

@funniray funniray commented May 17, 2022

This PR adds support for the Waterdog_XUID and Waterdog_IP fields in the ClientChainData when settings.waterdogpe is true. The functionality is similar to how Spigot deals with Bungeecord.

As there were changes to the lang folder, commit f6f851b would also need to be merged. Shouldn't be needed for PowerNukkit

This is the same PR as CloudburstMC/Nukkit#1986, just adapted to PowerNukkit.

@alikindsys alikindsys added Status: Awaiting Review The pull request is ready and needs to be reviewed by somebody to be merged Type: enhancement Enhancements and fixes to already existing features priority:1 Very critical. Feels bad without fix size/S Small Pull Request labels May 19, 2022
@LoboMetalurgico LoboMetalurgico changed the base branch from master to bleeding June 9, 2022 18:41
@LoboMetalurgico LoboMetalurgico added the Needs: Ingame Testing PRs that are waiting for ingame testing label Jun 11, 2022
@alikindsys
Copy link
Member

alikindsys commented Jun 26, 2022

Please open a pull request for f6f851b on https://github.com/PowerNukkit/PowerNukkit-Languages since that change is a requirement for this pull request

@alikindsys alikindsys added Status: Awaiting Response The issue or pull request is on hold because it needs more information and removed Status: Awaiting Review The pull request is ready and needs to be reviewed by somebody to be merged labels Jun 26, 2022
@funniray funniray requested a review from joserobjr as a code owner June 26, 2022 18:18
@funniray
Copy link
Author

Sorry, didn't realize that languages were handled differently on power-nukkit vs cloudburst's nukkit. I've went ahead and just added the option to default-nukkit.yml instead.

@irrld
Copy link

irrld commented Jun 26, 2022

I think it would look cleaner if you rename Waterdog_IP and Waterdog_XUID to waterdogIP and waterdogXUID

@LoboMetalurgico LoboMetalurgico added Status: Awaiting Review The pull request is ready and needs to be reviewed by somebody to be merged and removed Needs: Ingame Testing PRs that are waiting for ingame testing Status: Awaiting Response The issue or pull request is on hold because it needs more information labels Jul 2, 2022
@LoboMetalurgico
Copy link
Member

Hello, thanks for your Pull Request. Our team will make a small change to the isWaterdog function, where we will move it to the server class, so that we can expose it to the plugins.

You don't have to worry about anything and we thank you for making this implementation!

Copy link
Member

@LoboMetalurgico LoboMetalurgico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You!

@LoboMetalurgico LoboMetalurgico merged commit 98695b5 into PowerNukkit:bleeding Jul 3, 2022
@LoboMetalurgico LoboMetalurgico added Resolution: resolved The issue has been addressed or the request has been accepted and removed Status: Awaiting Review The pull request is ready and needs to be reviewed by somebody to be merged Status: Waiting for Code Owner labels Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:1 Very critical. Feels bad without fix Resolution: resolved The issue has been addressed or the request has been accepted size/S Small Pull Request Type: enhancement Enhancements and fixes to already existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants