fix: lazy replay received flag tracking should be in the wrapper #2405

pauldambra · 2025-10-06T20:55:33Z

lifting changes out of #2404

i want to make as many changes as possible before removing the lazy loaded code so i have a chance to back out of i need to

we're tracking received flag in the lazy loaded code, but not using it
and types are wrong... sessionRecording can be false but we don't represent that

vercel · 2025-10-06T20:55:43Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
posthog-js	Ready	Preview	Oct 6, 2025 9:04pm

greptile-apps

_{7 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

packages/browser/src/extensions/replay/triggerMatching.ts

packages/browser/src/extensions/replay/sessionrecording-wrapper.ts

github-actions · 2025-10-06T20:59:26Z

Download bundle size visualization

github-actions · 2025-10-06T21:02:38Z

Size Change: +1.26 kB (+0.02%)

Total Size: 5.11 MB

Filename	Size	Change
`packages/browser/dist/array.full.es5.js`	323 kB	+151 B (+0.05%)
`packages/browser/dist/array.full.js`	384 kB	+82 B (+0.02%)
`packages/browser/dist/array.full.no-external.js`	402 kB	+147 B (+0.04%)
`packages/browser/dist/array.js`	184 kB	+78 B (+0.04%)
`packages/browser/dist/array.no-external.js`	200 kB	+143 B (+0.07%)
`packages/browser/dist/lazy-recorder.js`	147 kB	+66 B (+0.04%)
`packages/browser/dist/main.js`	185 kB	+78 B (+0.04%)
`packages/browser/dist/module.full.js`	385 kB	+82 B (+0.02%)
`packages/browser/dist/module.full.no-external.js`	403 kB	+147 B (+0.04%)
`packages/browser/dist/module.js`	185 kB	+78 B (+0.04%)
`packages/browser/dist/module.no-external.js`	201 kB	+143 B (+0.07%)
`packages/browser/dist/posthog-recorder.js`	241 kB	+70 B (+0.03%)

ℹ️ View Unchanged

Filename	Size
`packages/ai/dist/anthropic/index.cjs`	16.7 kB
`packages/ai/dist/anthropic/index.mjs`	16.5 kB
`packages/ai/dist/gemini/index.cjs`	17.6 kB
`packages/ai/dist/gemini/index.mjs`	17.5 kB
`packages/ai/dist/index.cjs`	120 kB
`packages/ai/dist/index.mjs`	119 kB
`packages/ai/dist/langchain/index.cjs`	39.6 kB
`packages/ai/dist/langchain/index.mjs`	39 kB
`packages/ai/dist/openai/index.cjs`	29.8 kB
`packages/ai/dist/openai/index.mjs`	29.5 kB
`packages/ai/dist/vercel/index.cjs`	21.9 kB
`packages/ai/dist/vercel/index.mjs`	21.9 kB
`packages/browser/dist/all-external-dependencies.js`	223 kB
`packages/browser/dist/crisp-chat-integration.js`	1.97 kB
`packages/browser/dist/customizations.full.js`	19.3 kB
`packages/browser/dist/dead-clicks-autocapture.js`	12.6 kB
`packages/browser/dist/exception-autocapture.js`	11.6 kB
`packages/browser/dist/external-scripts-loader.js`	2.81 kB
`packages/browser/dist/intercom-integration.js`	2.02 kB
`packages/browser/dist/recorder-v2.js`	113 kB
`packages/browser/dist/recorder.js`	113 kB
`packages/browser/dist/surveys-preview.js`	71.1 kB
`packages/browser/dist/surveys.js`	80 kB
`packages/browser/dist/tracing-headers.js`	1.84 kB
`packages/browser/dist/web-vitals.js`	10.4 kB
`packages/browser/react/dist/esm/index.js`	15.1 kB
`packages/browser/react/dist/umd/index.js`	17.8 kB
`packages/core/dist/error-tracking/chunk-ids.js`	2.54 kB
`packages/core/dist/error-tracking/chunk-ids.mjs`	1.31 kB
`packages/core/dist/error-tracking/coercers/dom-exception-coercer.js`	2.3 kB
`packages/core/dist/error-tracking/coercers/dom-exception-coercer.mjs`	993 B
`packages/core/dist/error-tracking/coercers/error-coercer.js`	2.02 kB
`packages/core/dist/error-tracking/coercers/error-coercer.mjs`	794 B
`packages/core/dist/error-tracking/coercers/error-event-coercer.js`	1.76 kB
`packages/core/dist/error-tracking/coercers/error-event-coercer.mjs`	513 B
`packages/core/dist/error-tracking/coercers/event-coercer.js`	1.82 kB
`packages/core/dist/error-tracking/coercers/event-coercer.mjs`	548 B
`packages/core/dist/error-tracking/coercers/index.js`	6.79 kB
`packages/core/dist/error-tracking/coercers/index.mjs`	326 B
`packages/core/dist/error-tracking/coercers/object-coercer.js`	3.46 kB
`packages/core/dist/error-tracking/coercers/object-coercer.mjs`	2.07 kB
`packages/core/dist/error-tracking/coercers/primitive-coercer.js`	1.67 kB
`packages/core/dist/error-tracking/coercers/primitive-coercer.mjs`	419 B
`packages/core/dist/error-tracking/coercers/promise-rejection-event.js`	2.25 kB
`packages/core/dist/error-tracking/coercers/promise-rejection-event.mjs`	904 B
`packages/core/dist/error-tracking/coercers/string-coercer.js`	2.01 kB
`packages/core/dist/error-tracking/coercers/string-coercer.mjs`	820 B
`packages/core/dist/error-tracking/coercers/utils.js`	2.06 kB
`packages/core/dist/error-tracking/coercers/utils.mjs`	716 B
`packages/core/dist/error-tracking/error-properties-builder.js`	5.64 kB
`packages/core/dist/error-tracking/error-properties-builder.mjs`	4.24 kB
`packages/core/dist/error-tracking/index.js`	4.11 kB
`packages/core/dist/error-tracking/index.mjs`	152 B
`packages/core/dist/error-tracking/parsers/base.js`	2.62 kB
`packages/core/dist/error-tracking/parsers/base.mjs`	697 B
`packages/core/dist/error-tracking/parsers/chrome.js`	2.7 kB
`packages/core/dist/error-tracking/parsers/chrome.mjs`	1.29 kB
`packages/core/dist/error-tracking/parsers/gecko.js`	2.45 kB
`packages/core/dist/error-tracking/parsers/gecko.mjs`	1.11 kB
`packages/core/dist/error-tracking/parsers/index.js`	4.36 kB
`packages/core/dist/error-tracking/parsers/index.mjs`	1.92 kB
`packages/core/dist/error-tracking/parsers/node.js`	3.95 kB
`packages/core/dist/error-tracking/parsers/node.mjs`	2.68 kB
`packages/core/dist/error-tracking/parsers/opera.js`	2.22 kB
`packages/core/dist/error-tracking/parsers/opera.mjs`	706 B
`packages/core/dist/error-tracking/parsers/react-native.js`	203 B
`packages/core/dist/error-tracking/parsers/react-native.mjs`	0 B	🆕
`packages/core/dist/error-tracking/parsers/safari.js`	1.88 kB
`packages/core/dist/error-tracking/parsers/safari.mjs`	574 B
`packages/core/dist/error-tracking/parsers/winjs.js`	1.7 kB
`packages/core/dist/error-tracking/parsers/winjs.mjs`	406 B
`packages/core/dist/error-tracking/types.js`	1.33 kB
`packages/core/dist/error-tracking/types.mjs`	131 B
`packages/core/dist/error-tracking/utils.js`	1.8 kB
`packages/core/dist/error-tracking/utils.mjs`	604 B
`packages/core/dist/eventemitter.js`	1.78 kB
`packages/core/dist/eventemitter.mjs`	571 B
`packages/core/dist/featureFlagUtils.js`	6.5 kB
`packages/core/dist/featureFlagUtils.mjs`	4.28 kB
`packages/core/dist/gzip.js`	1.88 kB
`packages/core/dist/gzip.mjs`	577 B
`packages/core/dist/index.js`	5.7 kB
`packages/core/dist/index.mjs`	485 B
`packages/core/dist/posthog-core-stateless.js`	29.5 kB
`packages/core/dist/posthog-core-stateless.mjs`	27 kB
`packages/core/dist/posthog-core.js`	28.4 kB
`packages/core/dist/posthog-core.mjs`	24.3 kB
`packages/core/dist/testing/index.js`	2.93 kB
`packages/core/dist/testing/index.mjs`	79 B
`packages/core/dist/testing/PostHogCoreTestClient.js`	3.15 kB
`packages/core/dist/testing/PostHogCoreTestClient.mjs`	1.74 kB
`packages/core/dist/testing/test-utils.js`	2.71 kB
`packages/core/dist/testing/test-utils.mjs`	1.03 kB
`packages/core/dist/types.js`	8.2 kB
`packages/core/dist/types.mjs`	5.93 kB
`packages/core/dist/utils/bucketed-rate-limiter.js`	3.14 kB
`packages/core/dist/utils/bucketed-rate-limiter.mjs`	1.76 kB
`packages/core/dist/utils/index.js`	9.26 kB
`packages/core/dist/utils/index.mjs`	1.88 kB
`packages/core/dist/utils/number-utils.js`	2 kB
`packages/core/dist/utils/number-utils.mjs`	735 B
`packages/core/dist/utils/promise-queue.js`	2 kB
`packages/core/dist/utils/promise-queue.mjs`	768 B
`packages/core/dist/utils/string-utils.js`	1.91 kB
`packages/core/dist/utils/string-utils.mjs`	414 B
`packages/core/dist/utils/type-utils.js`	6.93 kB
`packages/core/dist/utils/type-utils.mjs`	3.03 kB
`packages/core/dist/vendor/uuidv7.js`	8.29 kB
`packages/core/dist/vendor/uuidv7.mjs`	6.72 kB
`packages/nextjs-config/dist/config.js`	5.51 kB
`packages/nextjs-config/dist/config.mjs`	4.03 kB
`packages/nextjs-config/dist/index.js`	2.24 kB
`packages/nextjs-config/dist/index.mjs`	30 B
`packages/nextjs-config/dist/utils.js`	6.06 kB
`packages/nextjs-config/dist/utils.mjs`	3.54 kB
`packages/nextjs-config/dist/utils.spec.js`	723 B
`packages/nextjs-config/dist/utils.spec.mjs`	455 B
`packages/nextjs-config/dist/webpack-plugin.js`	3.69 kB
`packages/nextjs-config/dist/webpack-plugin.mjs`	1.98 kB
`packages/node/dist/client.js`	22.6 kB
`packages/node/dist/client.mjs`	20.7 kB
`packages/node/dist/entrypoints/index.edge.js`	4.14 kB
`packages/node/dist/entrypoints/index.edge.mjs`	652 B
`packages/node/dist/entrypoints/index.node.js`	5.08 kB
`packages/node/dist/entrypoints/index.node.mjs`	901 B
`packages/node/dist/exports.js`	3.6 kB
`packages/node/dist/exports.mjs`	124 B
`packages/node/dist/extensions/error-tracking/autocapture.js`	2.65 kB
`packages/node/dist/extensions/error-tracking/autocapture.mjs`	1.23 kB
`packages/node/dist/extensions/error-tracking/index.js`	3.88 kB
`packages/node/dist/extensions/error-tracking/index.mjs`	2.61 kB
`packages/node/dist/extensions/error-tracking/modifiers/context-lines.node.js`	8.81 kB
`packages/node/dist/extensions/error-tracking/modifiers/context-lines.node.mjs`	7.15 kB
`packages/node/dist/extensions/error-tracking/modifiers/module.node.js`	2.78 kB
`packages/node/dist/extensions/error-tracking/modifiers/module.node.mjs`	1.45 kB
`packages/node/dist/extensions/express.js`	2.17 kB
`packages/node/dist/extensions/express.mjs`	548 B
`packages/node/dist/extensions/feature-flags/crypto-helpers.js`	2.72 kB
`packages/node/dist/extensions/feature-flags/crypto-helpers.mjs`	624 B
`packages/node/dist/extensions/feature-flags/crypto.js`	1.96 kB
`packages/node/dist/extensions/feature-flags/crypto.mjs`	673 B
`packages/node/dist/extensions/feature-flags/feature-flags.js`	26.8 kB
`packages/node/dist/extensions/feature-flags/feature-flags.mjs`	25 kB
`packages/node/dist/extensions/feature-flags/lazy.js`	1.89 kB
`packages/node/dist/extensions/feature-flags/lazy.mjs`	739 B
`packages/node/dist/extensions/sentry-integration.js`	4.7 kB
`packages/node/dist/extensions/sentry-integration.mjs`	3.21 kB
`packages/node/dist/storage-memory.js`	1.52 kB
`packages/node/dist/storage-memory.mjs`	297 B
`packages/node/dist/types.js`	603 B
`packages/node/dist/types.mjs`	0 B	🆕
`packages/node/dist/utils/logger.js`	2.16 kB
`packages/node/dist/utils/logger.mjs`	971 B
`packages/node/dist/version.js`	1.21 kB
`packages/node/dist/version.mjs`	45 B
`packages/react-native/dist/autocapture.js`	4.68 kB
`packages/react-native/dist/frameworks/wix-navigation.js`	1.3 kB
`packages/react-native/dist/hooks/useFeatureFlag.js`	1.49 kB
`packages/react-native/dist/hooks/useFeatureFlags.js`	821 B
`packages/react-native/dist/hooks/useNavigationTracker.js`	2.46 kB
`packages/react-native/dist/hooks/usePostHog.js`	467 B
`packages/react-native/dist/index.js`	3.12 kB
`packages/react-native/dist/native-deps.js`	13.9 kB
`packages/react-native/dist/optional/OptionalAsyncStorage.js`	299 B
`packages/react-native/dist/optional/OptionalExpoApplication.js`	377 B
`packages/react-native/dist/optional/OptionalExpoDevice.js`	347 B
`packages/react-native/dist/optional/OptionalExpoFileSystem.js`	386 B
`packages/react-native/dist/optional/OptionalExpoFileSystemLegacy.js`	423 B
`packages/react-native/dist/optional/OptionalExpoLocalization.js`	383 B
`packages/react-native/dist/optional/OptionalReactNativeDeviceInfo.js`	415 B
`packages/react-native/dist/optional/OptionalReactNativeLocalize.js`	303 B
`packages/react-native/dist/optional/OptionalReactNativeNavigation.js`	415 B
`packages/react-native/dist/optional/OptionalReactNativeNavigationWix.js`	443 B
`packages/react-native/dist/optional/OptionalReactNativeSafeArea.js`	644 B
`packages/react-native/dist/optional/OptionalSessionReplay.js`	455 B
`packages/react-native/dist/posthog-rn.js`	31.4 kB
`packages/react-native/dist/PostHogContext.js`	329 B
`packages/react-native/dist/PostHogProvider.js`	4.77 kB
`packages/react-native/dist/storage.js`	3.39 kB
`packages/react-native/dist/surveys/components/BottomSection.js`	1.34 kB
`packages/react-native/dist/surveys/components/Cancel.js`	909 B
`packages/react-native/dist/surveys/components/ConfirmationMessage.js`	1.58 kB
`packages/react-native/dist/surveys/components/QuestionHeader.js`	1.11 kB
`packages/react-native/dist/surveys/components/QuestionTypes.js`	10.1 kB
`packages/react-native/dist/surveys/components/SurveyModal.js`	3.86 kB
`packages/react-native/dist/surveys/components/Surveys.js`	7.18 kB
`packages/react-native/dist/surveys/getActiveMatchingSurveys.js`	3.48 kB
`packages/react-native/dist/surveys/icons.js`	7.76 kB
`packages/react-native/dist/surveys/index.js`	600 B
`packages/react-native/dist/surveys/PostHogSurveyProvider.js`	5.61 kB
`packages/react-native/dist/surveys/surveys-utils.js`	9.31 kB
`packages/react-native/dist/surveys/useActivatedSurveys.js`	3.38 kB
`packages/react-native/dist/surveys/useSurveyStorage.js`	2.16 kB
`packages/react-native/dist/types.js`	70 B
`packages/react-native/dist/version.js`	129 B
`packages/react/dist/esm/index.js`	15.1 kB
`packages/react/dist/umd/index.js`	17.8 kB
`packages/web/dist/index.cjs`	13.8 kB
`packages/web/dist/index.mjs`	13.7 kB
`tooling/rollup-utils/dist/index.js`	1.17 kB

_{compressed-size-action}

pauldambra · 2025-10-06T21:03:04Z

packages/browser/src/extensions/replay/sessionrecording-wrapper.ts

            const persistResponse = () => {
-                const sessionRecordingConfigResponse = response.sessionRecording
+                const sessionRecordingConfigResponse =
+                    response.sessionRecording === false ? undefined : response.sessionRecording


wild that we've never represented that sessionRecording can be false
it's "safe" to just treat it as undefined when false

fix: lazy replay received flag tracking should be in the wrapper

e4b262d

greptile-apps bot reviewed Oct 6, 2025

View reviewed changes

packages/browser/src/extensions/replay/triggerMatching.ts Show resolved Hide resolved

packages/browser/src/extensions/replay/sessionrecording-wrapper.ts Show resolved Hide resolved

fix

c54b2d4

pauldambra added the release label Oct 6, 2025

fix

f8c8748

pauldambra commented Oct 6, 2025

View reviewed changes

vercel bot deployed to Preview October 6, 2025 21:04 View deployment

pauldambra requested review from a team, TueHaulund and veryayskiy and removed request for a team October 6, 2025 21:05

TueHaulund approved these changes Oct 6, 2025

View reviewed changes

pauldambra merged commit cdfbd6d into main Oct 6, 2025
31 checks passed

pauldambra deleted the fix/push-received-flag-tracking-into-wraooer branch October 6, 2025 21:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: lazy replay received flag tracking should be in the wrapper #2405

fix: lazy replay received flag tracking should be in the wrapper #2405

Uh oh!

pauldambra commented Oct 6, 2025

Uh oh!

vercel bot commented Oct 6, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 6, 2025 •

edited

Loading

Uh oh!

pauldambra Oct 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: lazy replay received flag tracking should be in the wrapper #2405

fix: lazy replay received flag tracking should be in the wrapper #2405

Uh oh!

Conversation

pauldambra commented Oct 6, 2025

Uh oh!

vercel bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pauldambra Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Oct 6, 2025 •

edited

Loading

github-actions bot commented Oct 6, 2025 •

edited

Loading

github-actions bot commented Oct 6, 2025 •

edited

Loading