feat: remove the eager loaded session replay code from the bundle #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pauldambra
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
packages/browser/src/__tests__/extensions/replay/sessionRecording-onRemoteConfig.test.ts
Outdated
Show resolved
Hide resolved
|
Size Change: -298 kB (-5.84%) ✅ Total Size: 4.8 MB
ℹ️ View Unchanged
|
pauldambra
requested review from
a team,
TueHaulund and
veryayskiy
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR removes the eager loaded session replay code from the browser bundle and switches to lazy loaded replay as the default, achieving significant bundle size reduction. The main changes include:
- Removal of the
SessionRecordingclass in favor of lazy loading implementation - Moving replay-related code to an
externaldirectory structure - Updating imports to use the new module organization
- Converting the
SessionRecordingWrapperto the primarySessionRecordingclass
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/browser/terser-mangled-names.json | Removes mangled names for eager loaded session recording methods |
| packages/browser/src/utils/globals.ts | Updates imports to use external replay modules and adds lazy-recorder extension type |
| packages/browser/src/types.ts | Updates imports to use external replay modules for type definitions |
| packages/browser/src/posthog-core.ts | Simplifies session recording initialization by removing eager loading logic |
| packages/browser/src/extensions/replay/sessionrecording.ts | Complete removal of the eager loaded session recording implementation |
| packages/browser/src/extensions/replay/session-recording.ts | Converts wrapper class to main SessionRecording class with simplified implementation |
| packages/browser/src/extensions/replay/external/ | Multiple files moved/updated to external directory for lazy loading |
| Various test files | Updates imports and test expectations to work with new lazy loading structure |
| .changeset/gentle-wings-retire.md | Documents the breaking change for version tracking |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/browser/src/extensions/replay/external/lazy-loaded-session-recorder.ts
Show resolved
Hide resolved
TueHaulund
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're running lazy loaded replay as the default
now we can remove the eager loaded replay and get the bundle savings
i believe that this doesn't break older clients expecting things to be loadable in some way 🙈
why do i believe that this is not a breaking change?
we haven't edited the recorder.js
so any existing array.js or npm install will load the recorder.js as before - no change
we haven't renamed any methods
we have moved/changed trigger matching but any existing array.js will have it bundled already it is not lazy loaded
we load a new lazy-recorder.js
so, if you have cached remote assets it doesn't matter because we load that new asset regardless of what all you have cached