Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider response to on-down which is not always desirable #178

Closed
andrey-git opened this issue Apr 2, 2017 · 1 comment
Closed

Slider response to on-down which is not always desirable #178

andrey-git opened this issue Apr 2, 2017 · 1 comment

Comments

@andrey-git
Copy link

Description

The paper-slider responds to down event on the container. This is not always desirable, as the user might be just accidentally putting the finger on the slider while trying to vertically scroll the page.

Expected outcome

Vertical scroll starting at the slider shouldn't update the slider.
Respond to tap event only or make this configurable: tap or down

Actual outcome

Vertical scroll starting at the slider changes slider value.

Live Demo

https://www.webcomponents.org/element/PolymerElements/paper-slider/demo/demo/index.html

Steps to reproduce

  1. Put a paper-slider element in the page.
  2. Open the page in a web browser.
  3. Put finger/mouse on the slider and try to scroll down.

Browsers Affected

All

@NovapaX
Copy link
Contributor

NovapaX commented Feb 22, 2018

This is simply fixed by changing

on-down="_bardown"

to on-mousedown="_bardown"
This is actually how it should behave from a UI/UX standpoint. (none of the sliders I've tried anywhere capture and act on touchstart on the bar on a touchscreen.)

NovapaX added a commit to NovapaX/paper-slider that referenced this issue Feb 22, 2018
Only a tap and a mousedown on the bar should alter the knob-position.
Fixes PolymerElements#178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants