-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add property for ignoring touch dragging on the slider bar #209
Conversation
Only a tap and a mousedown on the bar should alter the knob-position. Fixes PolymerElements#178
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
CLA signed |
CLAs look good, thanks! |
This is a bit more complicated than initially thought.
|
Only thing missing here is the ability to mousedown on the bar anywhere and start dragging.
oh wow... looks like I can't test the click event. |
This is a breaking change. Can you please hide this feature under a flag? I'm guessing you can do this in connected callback:
I'll see if i can figure out what's going on with mockInteractions |
I came up with a working solution that ignores tracking of touches on the slider bar, but allows tapping on the slider bar to set the knob position. |
Hmm, I think this will work. I have to run it through an internal suite of tests to see if it breaks anything; we may be able to push this through as a bug fix |
This PR slipped through the cracks. Will prioritize internal testing |
All tests pass. You're golden! |
Great! Thanks for your help! |
any idea on whether (and when) this can get pushed into a release? |
We've been moving to a weekly release committee / schedule. Expect to see an update on Friday |
Released a |
Only a tap and a mousedown on the bar should alter the knob-position.
Fixes #178