Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL-friendly align property for drawer #76

Merged
merged 2 commits into from
Feb 23, 2016
Merged

RTL-friendly align property for drawer #76

merged 2 commits into from
Feb 23, 2016

Conversation

keanulee
Copy link
Contributor

Fixes #37

cc @blasten

@blasten
Copy link
Contributor

blasten commented Feb 22, 2016

There appears to have a timing issue when _computePosition is called. I tried setting dir=rtl in the doc element and the position remained left. We might be able to set the position by calling _setPosition from the debouncer in resetLayout wdyt?

@keanulee
Copy link
Contributor Author

Ah yes, I can get drawer's computed direction (e.g. 'rtl') only after it is attached, which computed properties does not support.

@frankiefu
Copy link
Contributor

lgtm

frankiefu added a commit that referenced this pull request Feb 23, 2016
RTL-friendly align property for drawer
@frankiefu frankiefu merged commit 4bae6da into master Feb 23, 2016
@frankiefu frankiefu deleted the drawer-align branch February 23, 2016 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants