App Drawer #37
App Drawer #37
Conversation
| }, | ||
|
|
||
| _updateDocScroll: function() { | ||
| this.shouldEnableDocScroll(this.persistent || !this.opened); |
There was a problem hiding this comment.
Consider updating AppDocumentScrollBehavior to set overflow: hidden on body on mobile
| */ | ||
| toggleDrawer: function() { | ||
| this.opened = !this.opened; | ||
| this.listen(this.drawer, 'app-drawer-position-changed', '_resetLayout'); |
There was a problem hiding this comment.
this assumes the drawer is there at app-layout-drawer's attached time. It is possible that the drawer is appended dynamically and this will not work. How about just add the app-drawer-position-changed to the listeners object?
|
LGTM 👍 |
| @@ -156,7 +119,6 @@ | |||
| type: Boolean, | |||
| readOnly: true, | |||
| notify: true, | |||
| reflectToAttribute: true, | |||
There was a problem hiding this comment.
I think we actually want to keep this one so one can style stuffs based on the existence of narrow attribute. For example, in the publishing template here: https://github.com/PolymerLabs/app-layout/blob/drawer/templates/publishing/src/blog-app.html#L100
There was a problem hiding this comment.
When I first saw this I thought that that blog-app styling would not work because of :not([attribute]) selectors not matching properly in IE/Edge, but for some weird reason (selector matches a class as well, maybe?) it does work.
I'll add the reflectToAttribute back to narrow.
No description provided.