[wct] Updated Mocha to the latest version and regenerated a lockfile.#377
Merged
rictic merged 1 commit intoPolymer:masterfrom May 18, 2018
merlinnot:fix-issue-227
Merged
[wct] Updated Mocha to the latest version and regenerated a lockfile.#377rictic merged 1 commit intoPolymer:masterfrom merlinnot:fix-issue-227
rictic merged 1 commit intoPolymer:masterfrom
merlinnot:fix-issue-227
Conversation
rictic
approved these changes
May 16, 2018
Contributor
rictic
left a comment
rictic
left a comment
There was a problem hiding this comment.
This is separate from wct-browser-legacy, yeah?
|
|
||
| <!-- ## Unreleased --> | ||
| <!-- Add new, unreleased items here. --> | ||
| ### Security |
Contributor
There was a problem hiding this comment.
Preferred format is:
## Unreleased
* Updated Mocha to v5
Contributor
Author
|
Thank you for a review. Yes, this is separate from |
Contributor
Author
|
@rictic a friendly ping :) |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests and build are passing locally.
Resolves #227