Update packages to resolve many security audit warnings.#364
Merged
Conversation
rictic
changed the title
TimvdLippe
approved these changes
May 10, 2018
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
The changes to the lockfiles might clash with Brendans PR, so maybe it is better to merge his first?
packages/cli/src/polymer-cli.ts
Outdated
|
|
||
| const commandDefinitions = mergeArguments([command.args, globalArguments]); | ||
| const commandOptionsRaw = commandLineArgs(commandDefinitions, commandArgs); | ||
| console.log(`commandLineArgs: ${JSON.stringify(commandLineArgs, null, 2 |
Contributor
There was a problem hiding this comment.
Leftover debug statement I suppose?
| } finally { | ||
| unintercept(); | ||
| console.log('stdout from failed cli invocation:'); | ||
| console.log(stdout); |
Contributor
There was a problem hiding this comment.
Are these leftover as well?
Contributor
Author
There was a problem hiding this comment.
This are intended, the other ones aren't
Contributor
|
We are upgrading to Mocha 5 here, but we are not updating |
Contributor
|
So... #377? 😸 |
aomarks
approved these changes
May 16, 2018
justinfagnani
pushed a commit
that referenced
this pull request
Jul 10, 2018
…rl` instead of `originalUrl` (#364) * Manifest deserialization: create `convertedFilePath` from `convertedUrl` instead of `originalUrl`. * Add a test for `convertedUrl` -> `convertedFilePath` when reading manifests. * Check `url` in deserialized `PackageScan#exports`. * Refactor `fileMappingToScanResult`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.