Skip to content

Fix _transform in build to correspond to breakage from Typescript 2.8.3 Transform typings update #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aomarks merged 2 commits into from
May 3, 2018
Merged

Fix _transform in build to correspond to breakage from Typescript 2.8.3 Transform typings update #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a73a69b
Updating all package-locks results in broken build...
usergenic May 3, 2018
9debfc1
[build] Update _transform code to conform to new TypeScript 2.8.3 typ…
usergenic May 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,964 changes: 982 additions & 982 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

11,868 changes: 5,922 additions & 5,946 deletions packages/analyzer/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

1,300 changes: 650 additions & 650 deletions packages/browser-capabilities/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

30,885 changes: 7,894 additions & 22,991 deletions packages/build/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions packages/build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"@types/vinyl-fs": "^2.4.8",
"babel-preset-minify": "=0.4.0-alpha.caaefb4c",
"babylon": "^7.0.0-beta.42",
"css-slam": "^2.1.0",
"css-slam": "^2.1.1",
"dom5": "^3.0.0",
"gulp-if": "^2.0.2",
"html-minifier": "^3.5.10",
Expand Down Expand Up @@ -114,7 +114,7 @@
"temp": "^0.8.3",
"tsc-then": "^1.1.0",
"tslint": "^5.9.1",
"typescript": "^2.3.2",
"typescript": "^2.8.3",
"vinyl-fs-fake": "^1.1.0"
}
}
7 changes: 3 additions & 4 deletions packages/build/src/optimize-streams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ import File = require('vinyl');

const logger = logging.getLogger('cli.build.optimize-streams');

export type FileCB =
(error?: null|undefined|string|Partial<Error>, file?: File) => void;
export type FileCB = (error?: Error, file?: File) => void;
export type CSSOptimizeOptions = {
stripWhitespace?: boolean;
};
Expand Down Expand Up @@ -87,7 +86,7 @@ export class GenericOptimizeTransform extends Transform {
// when we have a better plan for excluding some files from optimization.
if (!file.path || file.path.indexOf('webcomponentsjs/') >= 0 ||
file.path.indexOf('webcomponentsjs\\') >= 0) {
callback(null, file);
callback(undefined, file);
return;
}

Expand All @@ -102,7 +101,7 @@ export class GenericOptimizeTransform extends Transform {
{err: error.message || error});
}
}
callback(null, file);
callback(undefined, file);
}
}

Expand Down
3 changes: 1 addition & 2 deletions packages/build/src/streams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,7 @@ export abstract class AsyncTransformStream<In extends {}, Out extends {}>
_transform(
input: In,
_encoding: string,
callback:
(error?: null|undefined|string|Partial<Error>, value?: Out) => void) {
callback: (error?: Error, value?: Out) => void) {
this._initializeOnce();
this._inputs.write(input).then(() => {
callback();
Expand Down
Loading