Skip to content

Fix _transform in build to correspond to breakage from Typescript 2.8.3 Transform typings update#309

Merged
aomarks merged 2 commits intomasterfrom
fix-build-typings-issue
May 3, 2018
Merged

Fix _transform in build to correspond to breakage from Typescript 2.8.3 Transform typings update#309
aomarks merged 2 commits intomasterfrom
fix-build-typings-issue

Conversation

@usergenic
Copy link
Copy Markdown
Contributor

@usergenic usergenic commented May 3, 2018

Separating this work out from #300 which is where I noticed the builds start failing. I created a new branch from master to verify it was unrelated to that work.

@usergenic
Copy link
Copy Markdown
Contributor Author

Had a fix in PolymerLabs/css-slam#19 that was the last piece of the puzzle. Waiting for CI now; build should be fixed now...

@usergenic usergenic changed the title Updating all package-locks results in broken build... Fix _transform in build to correspond to breakage from Typescript 2.8.3 Transform typings update May 3, 2018
@usergenic usergenic requested review from aomarks and rictic May 3, 2018 06:43
@aomarks aomarks merged commit 7139332 into master May 3, 2018
@usergenic usergenic deleted the fix-build-typings-issue branch May 3, 2018 13:51
@rictic
Copy link
Copy Markdown
Contributor

rictic commented May 3, 2018

Isn't Transform is a typing in the node typings, not in TypeScript 2.8.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants