Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.Loader name conflict #1

Closed
guybedford opened this issue Aug 8, 2013 · 4 comments
Closed

window.Loader name conflict #1

guybedford opened this issue Aug 8, 2013 · 4 comments

Comments

@guybedford
Copy link

I just ran into this when trying to implement the ES6 module loader polyfill (https://github.com/ModuleLoader/es6-module-loader) in a project alongside Polymer.

window.Loader is currently in the ES6 module specification as the native loader global. Since Polymer is aiming to sit in the same sort of timescale as these implementations, ideally it would use another global name for the loader.
@ghost ghost assigned sjmiles Aug 12, 2013
@dfreedm
Copy link
Member

dfreedm commented Aug 12, 2013

This is a bigger change than just in tools, as Loader is used all over. Tracking in Polymer/polymer#237

@addyosmani
Copy link
Member

Thanks @azakus. We really appreciate your help trying to resolve the naming conflicts :)

@dfreedm
Copy link
Member

dfreedm commented Sep 9, 2013

window.PolymerLoader has replaced window.Loader

@dfreedm dfreedm closed this as completed Sep 9, 2013
@guybedford
Copy link
Author

Amazing, thanks so much for pushing this through.

rictic added a commit that referenced this issue Apr 7, 2018
@rictic
Fix the build, option #1 (#429)
cee649c 
* Fix the build.

It looks like the node v4 typings don't include definitions for `console` anymore? Seems like a bug, but moving to node v6 typings fixes.

* Use an explicit default value for FSUrlLoader's root
rictic pushed a commit that referenced this issue Apr 7, 2018
@dfreedm
Merge pull request #1 from addyosmani/patch-1
af6be09 
Adds npm install snippet, minor formatting changes.
rictic pushed a commit that referenced this issue Apr 7, 2018
@justinfagnani
Merge pull request #1 from Polymer/initial
47bc9a7 
Initial move from polymer-cli
rictic pushed a commit that referenced this issue Apr 7, 2018
@justinfagnani
fix silent (!) build failure when several source filepaths cannot be …
17e5762 
…found (#276)

* add a (failing) test case for https://github.com/Polymer/polymer-cli/issues/936

* ensure the build fails when more than one source file is missing

The 'analyze' phase of the build process completes when all source files are analyzed (scanned). A source file is analized when all its dependencies are resolved or rejected. When the sources stream is complete, _all_ pending source file promises need to be rejected--not only the first one. If some of the deferred dependencies remain pending, the analysis of the toplevel source file never continues after 'await this._cache.dependencyGraph.whenReady(resolvedUrl);'. That leads of a premature end of the analysis phase (without any errors).

* update CHANGELOG

* add test for lazy-import with broken path (#1)

add a test case to verify that this PR also fixes the issue https://github.com/Polymer/polymer-cli/issues/904
rictic pushed a commit that referenced this issue Apr 7, 2018
@justinfagnani
Merge pull request #1 from Polymer/initial
12179f6 
Initial commit
justinfagnani added a commit that referenced this issue Apr 8, 2018
@justinfagnani
Merge pull request #1 from PolymerLabs/attributes
7f79ea6 
Add set/getAttribute
bicknellr pushed a commit that referenced this issue Apr 9, 2018
@FredKSchott
Merge pull request #1 from Polymer/new-lib-3
c24adab 
pull polymer workspaces logic into a standalone package
justinfagnani added a commit that referenced this issue Apr 10, 2018
@justinfagnani
Merge pull request #1 from Polymer/config-files
90a3bd4 
Add common config files
aomarks added a commit that referenced this issue Apr 12, 2018
@aomarks
Add JavaScript modules capability. (#1)
b224d8a
usergenic pushed a commit that referenced this issue Apr 13, 2018
@kevinpschaaf
Merge pull request #1 from Polymer/simplify-events
389ebc0 
Simplify events (less runner/mocha centric)
@usergenic usergenic mentioned this issue Apr 25, 2018
Closed
usergenic pushed a commit that referenced this issue Jun 7, 2018
@rictic @usergenic
Convert to typescript (#1)
6301d0e 
* convert to typescript

* Add a TODO to convert this library to use promises
justinfagnani added a commit that referenced this issue Jul 10, 2018
@justinfagnani
Merge pull request #1 from Polymer/wip
09d37d1 
Rough version of html2js with import and exports rewriting
@TimvdLippe TimvdLippe mentioned this issue Jan 2, 2019
Open
@justinfagnani justinfagnani mentioned this issue Jan 3, 2019
Closed
@pik pik mentioned this issue Jan 3, 2019
Open
@tiruvarur-ramanan tiruvarur-ramanan mentioned this issue Jan 3, 2019
Closed
@vieiro vieiro mentioned this issue Jan 3, 2019
Open
@davidmaxwaterman davidmaxwaterman mentioned this issue Jan 3, 2019
Open
@hyyan hyyan mentioned this issue Jan 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dfreedm @sjmiles @addyosmani @guybedford