Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad filepath in lazy import causes build to fail silently #2541

Open
jsilvermist opened this issue Oct 4, 2017 · 2 comments
Open

Bad filepath in lazy import causes build to fail silently #2541

jsilvermist opened this issue Oct 4, 2017 · 2 comments
Labels
Package: cli wontfix

Comments

@jsilvermist
Copy link
Contributor

Description

A lazy import with a bad path causes build to fail silently.

Versions & Environment

  • Polymer CLI: v1.5.5
  • node: v8.4.0
  • Operating System: Windows 10 - Version 1703 - Build 15063.608

Steps to Reproduce

Add a lazy import with an invalid file path and attempt to build. eg.

File contains:

<link rel="lazy-import" href="bad/path/page.html">

Run:

polymer build --preset es6-unbundled

Expected Results

$ polymer build --preset es6-unbundled
info:    Clearing build\ directory...
info:    (es6-unbundled) Building...

error:   Invalid file path at XX:XX in file.ext.
error:   Error: 1 error(s) occurred during build.
(or something along these lines with a stack trace)

Actual Results

$ polymer build --preset es6-unbundled
info:    Clearing build\ directory...
info:    (es6-unbundled) Building...

$ |

Note

When building with --verbose output cuts off after same line.
vlukashov referenced this issue in vlukashov/polymer-build Dec 8, 2017
@jsilvermist
add test for lazy-import with broken path (#1)
0b10299 
add a test case to verify that this PR also fixes the issue https://github.com/Polymer/polymer-cli/issues/904
justinfagnani referenced this issue in Polymer/polymer-build Dec 19, 2017
@justinfagnani
fix silent (!) build failure when several source filepaths cannot be …
17e5762 
…found (#276)

* add a (failing) test case for https://github.com/Polymer/polymer-cli/issues/936

* ensure the build fails when more than one source file is missing

The 'analyze' phase of the build process completes when all source files are analyzed (scanned). A source file is analized when all its dependencies are resolved or rejected. When the sources stream is complete, _all_ pending source file promises need to be rejected--not only the first one. If some of the deferred dependencies remain pending, the analysis of the toplevel source file never continues after 'await this._cache.dependencyGraph.whenReady(resolvedUrl);'. That leads of a premature end of the analysis phase (without any errors).

* update CHANGELOG

* add test for lazy-import with broken path (#1)

add a test case to verify that this PR also fixes the issue https://github.com/Polymer/polymer-cli/issues/904
@romulocintra
Copy link
Contributor

Any news about it !!! Someone took care about it!?

@aomarks aomarks transferred this issue from Polymer/polymer-cli Jan 3, 2019
@stale
Copy link

stale bot commented Mar 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: cli wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aomarks @romulocintra @jsilvermist